[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #584: [FLINK-31338] support infer parallelism for flink table store

["SteNicholas (via GitHub)" <gi...@apache.org>]

SteNicholas commented on code in PR #584:
URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1135385497


##########
flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java:
##########
@@ -82,6 +82,20 @@ public class FlinkConnectorOptions {
                                     + "By default, if this option is not defined, the planner will derive the parallelism "
                                     + "for each statement individually by also considering the global configuration.");
 
+    public static final ConfigOption<Boolean> INFER_SCAN_PARALLELISM =
+            ConfigOptions.key("scan.infer-parallelism")

Review Comment:
   IMO, user should not configure `scan.infer-parallelism` because inferring parallelism is default behavior that infers parallelism when `scan.parallelism` isn't set, and use `scan.parallelism` when `scan.parallelism` is set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org