You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2020/06/12 11:26:17 UTC

[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1693: Inline Google Font CSS, but failed in debug

Lofesa commented on issue #1693:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1693#issuecomment-643220553


   From the [doc](https://www.modpagespeed.com/doc/filter-css-inline-import) for inline_import_to_link :
   "..The "Inline @import to Link" filter converts a <style> tag consisting of **only** @import statements into the corresponding `<link>` tags". See the word "only".
   The inline_google_font_css, I think, only works with link label, not with @import.
   The result is that the google font css is not inlined.
   
   About the message, maybe is not rigth. When I have used google fonts, and the inline_google_font_css I get the message of unauthorized domain all time, but the css got inlined.
   Try to put the google font in their own link statement:
   `<link href="https://fonts.googleapis.com/css?family=Merriweather:300,300i" rel="stylesheet">`
   and make sure the `pagespeed GoogleFontCssInlineMaxBytes bytes;` is set to contain all the css for the google fonts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org