You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/10 02:05:02 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3409: [Enhancement] Do some code optimization[SendAsyncMessageProcessor]

Alonexc opened a new issue, #3409:
URL: https://github.com/apache/incubator-eventmesh/issues/3409

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/224204234-f1fc6518-e5ea-48af-978e-d87efa0b2263.png)
   ![image](https://user-images.githubusercontent.com/91315508/224204244-577eea1b-667b-4425-8e0e-8207b27b2c70.png)
   ![image](https://user-images.githubusercontent.com/91315508/224204253-0697c01e-7354-4261-93f7-eeacb4399ea6.png)
   located at:
   eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncMessageProcessor.java line 66,68,70,72,235,372
   
   
   ### Describe the solution you'd like
   
   a. change to 'private static final'.
   ![image](https://user-images.githubusercontent.com/91315508/224204294-d7d34346-681b-4a27-918b-8f905553c787.png)
   
   b. use Objects.requireNonNull()
   ![image](https://user-images.githubusercontent.com/91315508/224204322-93e26b9c-c9ad-490d-849f-0502975bca5f.png)
   
   c. remove this redundant jump. ‘return’
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] Alonexc commented on issue #3409: [Enhancement] Do some code optimization[SendAsyncMessageProcessor]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3409:
URL: https://github.com/apache/incubator-eventmesh/issues/3409#issuecomment-1471186039

   @TheR1sing3un Welcome to the EvntMesh community, you can start by submitting a pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] mytang0 closed issue #3409: [Enhancement] Do some code optimization[SendAsyncMessageProcessor]

Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 closed issue #3409: [Enhancement] Do some code optimization[SendAsyncMessageProcessor]
URL: https://github.com/apache/incubator-eventmesh/issues/3409


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] TheR1sing3un commented on issue #3409: [Enhancement] Do some code optimization[SendAsyncMessageProcessor]

Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on issue #3409:
URL: https://github.com/apache/incubator-eventmesh/issues/3409#issuecomment-1470278684

   I would like to fix it, could u assign it to me~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org