You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shawn Heisey (JIRA)" <ji...@apache.org> on 2014/02/17 19:26:19 UTC
[jira] [Commented] (SOLR-5604) Remove deprecations caused by
httpclient 4.3.x upgrade
[ https://issues.apache.org/jira/browse/SOLR-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903423#comment-13903423 ]
Shawn Heisey commented on SOLR-5604:
------------------------------------
In what qualifies as my spare time, I have been trying to address this.
Given the problems I see appear when I try to change it, I am thinking that HttpClientUtil cannot be changed, it just needs to be deprecated entirely.
I can create a new class called HttpClientBuilderUtil, but it would really be nothing more than a very thin wrapper over HttpClientBuilder. Is there any value in doing that, aside from the warm fuzzies a user might get from only using Solr methods and not needing to handle the external class directly?
We need to do something about all the HttpSolrServer methods that make changes to the HttpClient object after it's created. One option is to deprecate all those methods and have them throw exceptions unless the HttpClient object is one of the old types that can be modified. Another is slightly more complicated - create the HttpClient object as soon as the first request is made. If the HttpClient object has already been created, calling those methods would throw an exception, but if it hasn't, then it would alter a list of internal options for the HttpClient.
I am still willing to try and tackle this issue, but I have to admit that my experience level with HttpClient is low. Anyone who has ideas for how to proceed, please let me know.
> Remove deprecations caused by httpclient 4.3.x upgrade
> ------------------------------------------------------
>
> Key: SOLR-5604
> URL: https://issues.apache.org/jira/browse/SOLR-5604
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.7
> Reporter: Shawn Heisey
> Fix For: 4.7, 5.0
>
> Attachments: SOLR-5604-4x-just-lucene.patch
>
>
> SOLR-5590 upgraded httpclient in Solr and Lucene to version 4.3.x. This version deprecates a LOT of classes and methods, recommending that they all be replaced with various methods from the HttpClientBuilder class.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org