You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/07 06:00:18 UTC
[GitHub] [incubator-superset] craig-rueda opened a new pull request #9099:
Moving away from using the root logger everywhere
craig-rueda opened a new pull request #9099: Moving away from using the root logger everywhere
URL: https://github.com/apache/incubator-superset/pull/9099
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [x] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
logging.xxx(<log message here>) has the effect of logging directly to the ROOT logger regardless of the module that's writing out the given message. Instead of following this pattern, it's best practice to instead fetch the logger for each module at init and then use it for all logging within said module. This allows for tuning of log levels on a per module basis.
### Test Plan
I intend to deploy to testing environment and verify logs. This may also affect log messages when runing CLI, so that should be looked at as well.
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #9099: Moving
away from using the root logger everywhere
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #9099: Moving away from using the root logger everywhere
URL: https://github.com/apache/incubator-superset/pull/9099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request
#9099: Moving away from using the root logger everywhere
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9099: Moving away from using the root logger everywhere
URL: https://github.com/apache/incubator-superset/pull/9099#discussion_r376515519
##########
File path: superset/views/base_api.py
##########
@@ -62,7 +63,6 @@ class BaseSupersetModelRestApi(ModelRestApi):
Extends FAB's ModelResApi to implement specific superset generic functionality
"""
- logger = logging.getLogger(__name__)
Review comment:
There are a bunch of `self.logger.` that need to change to `logger` also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org