You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/13 17:03:37 UTC

[GitHub] [maven-ear-plugin] mabrarov opened a new pull request #22: [MEAR-216] - Handling test JARs as regular JARs

mabrarov opened a new pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22


   [MEAR-216] - Handling test JARs as regular JARs


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-739505049


   Merged conflicts were resolved. Please trigger a new Jenkins build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] hboutemy merged pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
hboutemy merged pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-710698128


   It looks like Jenkins build passed successfully. What needs to be done to merge this pull request and close MEAR-216?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-714485368


   Need to check one more case I found recently. The case (I'll add a test for it) may demonstrate that this pull request is wrong and needs further work. Please, don't merge this pull request until I reply with result of my check.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] elharo commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-709123049


   https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/mear-216/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
mabrarov edited a comment on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-710698128


   @elharo,
   
   Sorry for being noisy and disrupting you, but it looks like Jenkins build passed successfully. What needs to be done to merge this pull request and close MEAR-216?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-714766910


   I fixed [that issue](https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-714485368) and this pull request is ready for review now.
   
   @elharo and @hboutemy, your help with Jenkins build, review and merging is appreciated.
   
   Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-748573495


   @elharo and @hboutemy, is it possible to get this PR merged? What's missing / pending or blocking this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] hboutemy commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-748583938


   you're right, merged
   thank you


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-739536070


   This PR was successfully built by Jenkins. Is it possible to get this PR merged?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-708177841


   @elharo, could you please trigger Jenkins build for this pull request?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org