You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/30 15:27:51 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3451: [Fix] Fix bug that rowset meta is deleted after compaction
morningman opened a new pull request #3451:
URL: https://github.com/apache/incubator-doris/pull/3451
After compaction, the tablet rowset meta will be modified by
adding to new output rowsets and deleting the old input rowsets.
The output version may equals to the input version.
So we should delete the "input" version from _rs_version_map
before adding the "output" version to _rs_version_map. Otherwise,
the new "output" version will be lost in _rs_version_map.
Fix #3450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #3451: [Fix] Fix bug that rowset meta is deleted after compaction
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #3451:
URL: https://github.com/apache/incubator-doris/pull/3451#issuecomment-622382513
> @morningman Hi, How do we avoid this bug happen again？do we need add a compaction test framework to cover all compaction test cases?
Agreed, I will try to find a way to implement it later.
By the way, could you help me to approve this PR again? I just fix a ut bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on pull request #3451: [Fix] Fix bug that rowset meta is deleted after compaction
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #3451:
URL: https://github.com/apache/incubator-doris/pull/3451#issuecomment-622645340
> > @morningman Hi, How do we avoid this bug happen again？do we need add a compaction test framework to cover all compaction test cases?
>
> Agreed, I will try to find a way to implement it later.
> By the way, could you help me to approve this PR again? I just fix a ut bug.
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on pull request #3451: [Fix] Fix bug that rowset meta is deleted after compaction
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #3451:
URL: https://github.com/apache/incubator-doris/pull/3451#issuecomment-622342997
@morningman Hi, How do we avoid this bug happen again？do we need add a compaction test framework to cover all compaction test cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org