You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2018/11/23 23:08:41 UTC

svn commit: r1847326 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

Author: markt
Date: Fri Nov 23 23:08:41 2018
New Revision: 1847326

URL: http://svn.apache.org/viewvc?rev=1847326&view=rev
Log:
Fix IDE nags

Modified:
    tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

Modified: tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java?rev=1847326&r1=1847325&r2=1847326&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java (original)
+++ tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java Fri Nov 23 23:08:41 2018
@@ -350,7 +350,7 @@ public class TestEncryptInterceptor {
         dest.messageReceived(msg);
     }
 
-    /**
+    /*
      * This test isn't guaranteed to catch any multithreaded issues, but it
      * gives a good exercise.
      */
@@ -367,6 +367,7 @@ public class TestEncryptInterceptor {
         dest.start(Channel.SND_TX_SEQ);
 
         Runnable job = new Runnable() {
+            @Override
             public void run() {
                 try {
                     ChannelData msg = new ChannelData(false);
@@ -456,7 +457,7 @@ public class TestEncryptInterceptor {
     private static class ValuesCaptureInterceptor
         extends ChannelInterceptorBase
     {
-        private ArrayList<byte[]> messages = new ArrayList<byte[]>();
+        private ArrayList<byte[]> messages = new ArrayList<>();
 
         @Override
         public void sendMessage(Member[] destination, ChannelMessage msg, InterceptorPayload payload)



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1847326 - /tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

Posted by Christopher Schultz <ch...@christopherschultz.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Mark,

On 11/23/18 18:08, markt@apache.org wrote:
> Author: markt Date: Fri Nov 23 23:08:41 2018 New Revision: 1847326
> 
> URL: http://svn.apache.org/viewvc?rev=1847326&view=rev Log: Fix IDE
> nags
> 
> Modified: 
> tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEn
cryptInterceptor.java
>
>  Modified:
> tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEn
cryptInterceptor.java
>
> 
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribe
s/group/interceptors/TestEncryptInterceptor.java?rev=1847326&r1=1847325&
r2=1847326&view=diff
> ======================================================================
========
>
> 
- ---
tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncr
yptInterceptor.java
(original)
> +++
> tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEn
cryptInterceptor.java
> Fri Nov 23 23:08:41 2018 @@ -350,7 +350,7 @@ public class
> TestEncryptInterceptor { dest.messageReceived(msg); }
> 
> -    /** +    /* * This test isn't guaranteed to catch any
> multithreaded issues, but it * gives a good exercise. */

This wasn't intended to be Javadoc... just a multiline comment.

> @@ -367,6 +367,7 @@ public class TestEncryptInterceptor { 
> dest.start(Channel.SND_TX_SEQ);
> 
> Runnable job = new Runnable() { +            @Override public void
> run() { try { ChannelData msg = new ChannelData(false); @@ -456,7
> +457,7 @@ public class TestEncryptInterceptor { private static
> class ValuesCaptureInterceptor extends ChannelInterceptorBase { -
> private ArrayList<byte[]> messages = new ArrayList<byte[]>(); +
> private ArrayList<byte[]> messages = new ArrayList<>();


I used new ArrayList<byte[]> so that back-porting wouldn't require too
much tweaking.

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlv5fXoACgkQHPApP6U8
pFiA2BAAlEgFoWUbLtcXSdO9glq49HrTjcf6QNAkmg+bpXlWl8Hg4XtKsdlsHv9A
Ouj/4C/YxB/WPlj2pV+hrslGmTsX1MwsR5HCj2ZvwLkXumD3aZEQuN5RBl2EZljE
OQ7ObCa1maN9B9OXOHMf5i9KYOdiwUTtlbDz8y151MZjrKH0q26U27NptlK2VFhH
bK2MiYHTDmt80EB/I7tn3eHHM5wrmCyiAVW1ArnMFCrs5bAE7okEMNz5fmdYJQla
Ui09OttJa3kFR++tfukBInvDE95cugcKThA+lORrvdkJ9hmT3v6/6fYkZVWQOtSc
5/07fb1rTxm5wSoU2E4Q/MDanpWZWY84tgz88u36EiLzhUGQ4Paf5xNlgPcce+2h
GgM5HKBxDiK3d9AWmQuBFRuTjjELRg8XCiXY7VqwE6n35ytyhRZ9qNmQ7Lcth0S1
syHgVYZZUaFd8wY7BdI7MiWxua6hZ8KUYasU9SWVi1JUZ3ehYLVLkKm7hdP0yqY3
sCya9lrK76H8R6a50CYcG0ijR9HvjlJv+pOm/9u8hHj2/ZN55ymkCKf+rf3doZDv
CL78xOpEYO6X0NJ7pS6uCwQ9Xw486TG2KuXO1aExV+xDrya4zK5S0Fi7//CWdPSL
1FkB3yVXNTKIUeIFnAphdZfkxKb1KfGs8K1rC/tY7fAhsUZzYM4=
=cpn4
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org