You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Raja Aluri (JIRA)" <ji...@apache.org> on 2012/11/07 02:22:19 UTC
[jira] [Created] (ZOOKEEPER-1574) mismatched CR/LF endings in text
files
Raja Aluri created ZOOKEEPER-1574:
-------------------------------------
Summary: mismatched CR/LF endings in text files
Key: ZOOKEEPER-1574
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1574
Project: ZooKeeper
Issue Type: Bug
Reporter: Raja Aluri
Source code in zookeeper repo has a bunch of files that have CRLF endings.
With more development happening on windows there is a higher chance of more CRLF files getting into the source tree.
I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
But before adding the .gitattributes file we need to normalize the existing tree, so that people when they sync after .giattributes change wont end up with a bunch of modified files in their workspace.
I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
[http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in]
[http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git]
I will submit a separate bug and patch for .gitattributes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1574) mismatched CR/LF endings in text
files
Posted by "Raja Aluri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raja Aluri updated ZOOKEEPER-1574:
----------------------------------
Attachment: ZOOKEEPER-1574.trunk.patch
> mismatched CR/LF endings in text files
> --------------------------------------
>
> Key: ZOOKEEPER-1574
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1574
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Raja Aluri
> Attachments: ZOOKEEPER-1574.trunk.patch
>
>
> Source code in zookeeper repo has a bunch of files that have CRLF endings.
> With more development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> But before adding the .gitattributes file we need to normalize the existing tree, so that people when they sync after .giattributes change wont end up with a bunch of modified files in their workspace.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> [http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in]
> [http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git]
> I will submit a separate bug and patch for .gitattributes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1574) mismatched CR/LF endings in
text files
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492058#comment-13492058 ]
Hadoop QA commented on ZOOKEEPER-1574:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552387/ZOOKEEPER-1574.trunk.patch
against trunk revision 1404288.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 17 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1252//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1252//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1252//console
This message is automatically generated.
> mismatched CR/LF endings in text files
> --------------------------------------
>
> Key: ZOOKEEPER-1574
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1574
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Raja Aluri
> Attachments: ZOOKEEPER-1574.trunk.patch
>
>
> Source code in zookeeper repo has a bunch of files that have CRLF endings.
> With more development happening on windows there is a higher chance of more CRLF files getting into the source tree.
> I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
> But before adding the .gitattributes file we need to normalize the existing tree, so that people when they sync after .giattributes change wont end up with a bunch of modified files in their workspace.
> I am adding a couple of links here to give more primer on what exactly is the issue and how we are trying to fix it.
> [http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in]
> [http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git]
> I will submit a separate bug and patch for .gitattributes
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira