You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/02 01:19:12 UTC
[GitHub] [iceberg] jackye1995 opened a new pull request #2776: Build: bump up DiffPlug Spotless version
jackye1995 opened a new pull request #2776:
URL: https://github.com/apache/iceberg/pull/2776
We are using a version of spotless plugin that is vulnerable to attack https://nvd.nist.gov/vuln/detail/CVE-2019-9843, thus bumping up the version to 3.20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a change in pull request #2776: Build: bump up DiffPlug Spotless version
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #2776:
URL: https://github.com/apache/iceberg/pull/2776#discussion_r662971747
##########
File path: build.gradle
##########
@@ -27,7 +27,7 @@ buildscript {
classpath 'com.github.jengelman.gradle.plugins:shadow:5.0.0'
classpath 'com.palantir.baseline:gradle-baseline-java:3.36.2'
classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.12.3'
- classpath 'com.diffplug.spotless:spotless-plugin-gradle:3.14.0'
+ classpath 'com.diffplug.spotless:spotless-plugin-gradle:3.20.0'
Review comment:
maybe worth bumping to the latest version, which is `5.14.0`?
##########
File path: build.gradle
##########
@@ -27,7 +27,7 @@ buildscript {
classpath 'com.github.jengelman.gradle.plugins:shadow:5.0.0'
classpath 'com.palantir.baseline:gradle-baseline-java:3.36.2'
classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.12.3'
- classpath 'com.diffplug.spotless:spotless-plugin-gradle:3.14.0'
+ classpath 'com.diffplug.spotless:spotless-plugin-gradle:3.20.0'
Review comment:
maybe worth bumping to the latest version, which is `5.14.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] yyanyy merged pull request #2776: Build: bump up DiffPlug Spotless version
Posted by GitBox <gi...@apache.org>.
yyanyy merged pull request #2776:
URL: https://github.com/apache/iceberg/pull/2776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #2776: Build: bump up DiffPlug Spotless version
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #2776:
URL: https://github.com/apache/iceberg/pull/2776#discussion_r663073240
##########
File path: build.gradle
##########
@@ -27,7 +27,7 @@ buildscript {
classpath 'com.github.jengelman.gradle.plugins:shadow:5.0.0'
classpath 'com.palantir.baseline:gradle-baseline-java:3.36.2'
classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.12.3'
- classpath 'com.diffplug.spotless:spotless-plugin-gradle:3.14.0'
+ classpath 'com.diffplug.spotless:spotless-plugin-gradle:3.20.0'
Review comment:
Not sure if bumping the major version would cause issue, but let me try 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org