You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/08/08 14:42:52 UTC

[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1123: [#299] improvement: Make config type of RSS_STORAGE_TYPE as enum

codecov-commenter commented on PR #1123:
URL: https://github.com/apache/incubator-uniffle/pull/1123#issuecomment-1669759337

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1123](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c4dd7a6) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/ca245316c3f5002de117adb7f550d3198fb7f6e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ca24531) will **increase** coverage by `0.99%`.
   > The diff coverage is `38.09%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1123      +/-   ##
   ============================================
   + Coverage     54.16%   55.16%   +0.99%     
   + Complexity     2552     2092     -460     
   ============================================
     Files           387      316      -71     
     Lines         21940    14071    -7869     
     Branches       1819     1264     -555     
   ============================================
   - Hits          11884     7762    -4122     
   + Misses         9357     5893    -3464     
   + Partials        699      416     -283     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...in/java/org/apache/uniffle/common/StorageType.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TdG9yYWdlVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...pache/uniffle/server/ShuffleServerGrpcService.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyR3JwY1NlcnZpY2UuamF2YQ==) | `0.76% <0.00%> (-0.01%)` | :arrow_down: |
   | [.../org/apache/uniffle/server/ShuffleTaskManager.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlVGFza01hbmFnZXIuamF2YQ==) | `76.63% <0.00%> (ø)` | |
   | [...niffle/server/netty/ShuffleServerNettyHandler.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9uZXR0eS9TaHVmZmxlU2VydmVyTmV0dHlIYW5kbGVyLmphdmE=) | `1.47% <0.00%> (-0.01%)` | :arrow_down: |
   | [.../org/apache/uniffle/common/config/RssBaseConf.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9jb25maWcvUnNzQmFzZUNvbmYuamF2YQ==) | `96.75% <100.00%> (ø)` | |
   | [...pache/uniffle/server/DefaultFlushEventHandler.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9EZWZhdWx0Rmx1c2hFdmVudEhhbmRsZXIuamF2YQ==) | `87.09% <100.00%> (+0.21%)` | :arrow_up: |
   | [...org/apache/uniffle/server/LocalStorageChecker.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9Mb2NhbFN0b3JhZ2VDaGVja2VyLmphdmE=) | `65.92% <100.00%> (ø)` | |
   | [...org/apache/uniffle/server/ShuffleFlushManager.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlRmx1c2hNYW5hZ2VyLmphdmE=) | `75.86% <100.00%> (ø)` | |
   | [.../java/org/apache/uniffle/server/ShuffleServer.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyLmphdmE=) | `62.75% <100.00%> (-1.22%)` | :arrow_down: |
   | [.../uniffle/server/storage/StorageManagerFactory.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9zdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyRmFjdG9yeS5qYXZh) | `75.00% <100.00%> (ø)` | |
   
   ... and [74 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1123/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org