You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/07 09:08:50 UTC

[GitHub] [inlong] gong opened a new pull request, #5819: [INLONG-5818][Sort] Fix pulsar connector metric computing

gong opened a new pull request, #5819:
URL: https://github.com/apache/inlong/pull/5819

   ### Prepare a Pull Request
   
   - [INLONG-5818][Sort] Fix pulsar connector metric computing
   
   - Fixes #5818 
   
   ### Motivation
   
   Fix pulsar connector metric computing
   
   ### Modifications
   
   * Modify log to slf4j
   * Change metric computing 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow merged pull request #5819: [INLONG-5818][Sort] Fix metric computing for Pulsar connector

Posted by GitBox <gi...@apache.org>.
healchow merged PR #5819:
URL: https://github.com/apache/inlong/pull/5819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #5819: [INLONG-5818][Sort] Fix pulsar connector metric computing

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5819:
URL: https://github.com/apache/inlong/pull/5819#discussion_r964604660


##########
inlong-sort/sort-formats/format-inlongmsg-base/src/main/java/org/apache/inlong/sort/formats/inlongmsg/InLongMsgDeserializationSchema.java:
##########
@@ -38,6 +39,8 @@
 
 public class InLongMsgDeserializationSchema implements DeserializationSchema<RowData> {
 
+    private static final Logger log = LoggerFactory.getLogger(InLongMsgDeserializationSchema.class);

Review Comment:
   For static final variable, suggest using UPPER case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org