[jira] [Commented] (TS-2236) fabricate_with_old_api adds zero byte at the end of the response body

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018992#comment-14018992 ] 

ASF subversion and git services commented on TS-2236:
-----------------------------------------------------

Commit 1b57f42af928f76da298c97ea24a2b50dab58bc3 in trafficserver's branch refs/heads/master from [~thachtran]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=1b57f42 ]

TS-2236: remove trailing null in response body set by fabricate_with_old_api

I'm seeing this too whenever a remap plugin set an error response
body using TSHttpTxnErrorBodySet.  I think the bug is simply failed
to realise that ink_bvsprintf will return resulting len including
the final null.


> fabricate_with_old_api adds zero byte at the end of the response body
> ---------------------------------------------------------------------
>
>                 Key: TS-2236
>                 URL: https://issues.apache.org/jira/browse/TS-2236
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: portl4t
>            Assignee: portl4t
>             Fix For: sometime
>
>         Attachments: TS-2236.patch
>
>
> When ts decides to response error to ua, fabricate_with_old_api(...) will be called, and sometimes internal_msg_buffer_size will be set as strlen(internal_msg_buffer) + 1, including the last zero byte, so the client will receive a response which has a zero byte at the end of the body, should we remove the last zero byte?



--
This message was sent by Atlassian JIRA
(v6.2#6252)