You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Adam Winer <aw...@google.com> on 2009/02/23 21:03:34 UTC
Add "src/" directory in features
Any objections to creating a "/src" directory underneath "/features"
and putting all source in there? The lack of this level of hierarchy
is causing havoc with Maven builds, e.g. my current drive includes the
following directory structure:
features/target//classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/opensocial-templates
If anyone needs me to hold off, let me know.
-- Adam Winer
Re: Add "src/" directory in features
Posted by Paul Lindner <pl...@hi5.com>.
This change and the features directory reorg is now committed to trunk.
On Feb 23, 2009, at 1:36 PM, Chris Chabot wrote:
> Indeed, php doesn't touch anything other then:
>
> <features_path>/feature.txt
>
> for each feature in feature.txt:
> <features_path>/<feature>/feature.xml
>
> for each js file in feature.xml
> <features_path>/<feature>/<js file>.js
>
> And that's really everything it touches, so as long as the
> 'features_path'
> is pointing at the right spot (ie add the '/src' bit to it),
> everything will
> keep on working as it should :)
>
> Thanks for taking care of this!
>
> -- Chris
>
>
> On Mon, Feb 23, 2009 at 10:21 PM, Paul Lindner <pl...@hi5.com>
> wrote:
>
>> I don't believe that you depend on the javascript tests, so yes,
>> this will
>> work.
>>
>> Before committing I will insure that php is working.
>>
>> Thanks!
>>
>>
>> On Feb 23, 2009, at 1:15 PM, Chris Chabot wrote:
>>
>> Just so I don't mis-understand, this is just moving the entire
>> structure
>>> that is now under /features/* to /features/src/* right?
>>>
>>> If that is indeed correct, then please also adjust
>>> php/config/container.php,
>>> the line that reads:
>>>
>>> 'features_path' => realpath(dirname(__FILE__) . '/../../
>>> features') . '/',
>>>
>>> to:
>>>
>>> 'features_path' => realpath(dirname(__FILE__) . '/../../features/
>>> src') .
>>> '/',
>>>
>>> Since EOD US time zone is deep-asleep-already time zone here, it
>>> would be
>>> swell if you could also please make sure not to leave php-shindig
>>> broken
>>> for
>>> a few hours :)
>>>
>>> Thanks!
>>>
>>> -- Chris
>>>
>>>
>>> On Mon, Feb 23, 2009 at 9:28 PM, Paul Lindner <pl...@hi5.com>
>>> wrote:
>>>
>>> Okay, if no objections by EOD I will execute the changes
>>> referenced in
>>>> SHINDIG-806..
>>>>
>>>>
>>>>
>>>> On Feb 23, 2009, at 12:26 PM, Louis Ryan wrote:
>>>>
>>>> +10000
>>>>
>>>>>
>>>>> On Mon, Feb 23, 2009 at 12:20 PM, Paul Lindner <pl...@hi5.com>
>>>>> wrote:
>>>>>
>>>>> There's already an issue for this:
>>>>>
>>>>>>
>>>>>> https://issues.apache.org/jira/browse/SHINDIG-806
>>>>>>
>>>>>> I'm okay with this just so long as it's done with proper svn mv
>>>>>> commands.
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Feb 23, 2009, at 12:13 PM, Vincent Siveton wrote:
>>>>>>
>>>>>> +1
>>>>>>
>>>>>>
>>>>>>> Vincent
>>>>>>>
>>>>>>> 2009/2/23, Adam Winer <aw...@google.com>:
>>>>>>>
>>>>>>> Any objections to creating a "/src" directory underneath "/
>>>>>>> features"
>>>>>>>
>>>>>>>> and putting all source in there? The lack of this level of
>>>>>>>> hierarchy
>>>>>>>> is causing havoc with Maven builds, e.g. my current drive
>>>>>>>> includes
>>>>>>>> the
>>>>>>>> following directory structure:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> features/target//classes/features/target/classes/features/
>>>>>>>> target/classes/features/target/classes/features/target/
>>>>>>>> classes/features/target/classes/features/target/classes/
>>>>>>>> features/target/classes/features/target/classes/features/
>>>>>>>> target/classes/features/target/classes/features/target/
>>>>>>>> classes/opensocial-templates
>>>>>>>>
>>>>>>>> If anyone needs me to hold off, let me know.
>>>>>>>>
>>>>>>>>
>>>>>>>> -- Adam Winer
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>
>>
Re: Add "src/" directory in features
Posted by Chris Chabot <ch...@google.com>.
Indeed, php doesn't touch anything other then:
<features_path>/feature.txt
for each feature in feature.txt:
<features_path>/<feature>/feature.xml
for each js file in feature.xml
<features_path>/<feature>/<js file>.js
And that's really everything it touches, so as long as the 'features_path'
is pointing at the right spot (ie add the '/src' bit to it), everything will
keep on working as it should :)
Thanks for taking care of this!
-- Chris
On Mon, Feb 23, 2009 at 10:21 PM, Paul Lindner <pl...@hi5.com> wrote:
> I don't believe that you depend on the javascript tests, so yes, this will
> work.
>
> Before committing I will insure that php is working.
>
> Thanks!
>
>
> On Feb 23, 2009, at 1:15 PM, Chris Chabot wrote:
>
> Just so I don't mis-understand, this is just moving the entire structure
>> that is now under /features/* to /features/src/* right?
>>
>> If that is indeed correct, then please also adjust
>> php/config/container.php,
>> the line that reads:
>>
>> 'features_path' => realpath(dirname(__FILE__) . '/../../features') . '/',
>>
>> to:
>>
>> 'features_path' => realpath(dirname(__FILE__) . '/../../features/src') .
>> '/',
>>
>> Since EOD US time zone is deep-asleep-already time zone here, it would be
>> swell if you could also please make sure not to leave php-shindig broken
>> for
>> a few hours :)
>>
>> Thanks!
>>
>> -- Chris
>>
>>
>> On Mon, Feb 23, 2009 at 9:28 PM, Paul Lindner <pl...@hi5.com> wrote:
>>
>> Okay, if no objections by EOD I will execute the changes referenced in
>>> SHINDIG-806..
>>>
>>>
>>>
>>> On Feb 23, 2009, at 12:26 PM, Louis Ryan wrote:
>>>
>>> +10000
>>>
>>>>
>>>> On Mon, Feb 23, 2009 at 12:20 PM, Paul Lindner <pl...@hi5.com>
>>>> wrote:
>>>>
>>>> There's already an issue for this:
>>>>
>>>>>
>>>>> https://issues.apache.org/jira/browse/SHINDIG-806
>>>>>
>>>>> I'm okay with this just so long as it's done with proper svn mv
>>>>> commands.
>>>>>
>>>>>
>>>>>
>>>>> On Feb 23, 2009, at 12:13 PM, Vincent Siveton wrote:
>>>>>
>>>>> +1
>>>>>
>>>>>
>>>>>> Vincent
>>>>>>
>>>>>> 2009/2/23, Adam Winer <aw...@google.com>:
>>>>>>
>>>>>> Any objections to creating a "/src" directory underneath "/features"
>>>>>>
>>>>>>> and putting all source in there? The lack of this level of hierarchy
>>>>>>> is causing havoc with Maven builds, e.g. my current drive includes
>>>>>>> the
>>>>>>> following directory structure:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> features/target//classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/opensocial-templates
>>>>>>>
>>>>>>> If anyone needs me to hold off, let me know.
>>>>>>>
>>>>>>>
>>>>>>> -- Adam Winer
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>
>
Re: Add "src/" directory in features
Posted by Paul Lindner <pl...@hi5.com>.
I don't believe that you depend on the javascript tests, so yes, this
will work.
Before committing I will insure that php is working.
Thanks!
On Feb 23, 2009, at 1:15 PM, Chris Chabot wrote:
> Just so I don't mis-understand, this is just moving the entire
> structure
> that is now under /features/* to /features/src/* right?
>
> If that is indeed correct, then please also adjust php/config/
> container.php,
> the line that reads:
>
> 'features_path' => realpath(dirname(__FILE__) . '/../../features') .
> '/',
>
> to:
>
> 'features_path' => realpath(dirname(__FILE__) . '/../../features/
> src') .
> '/',
>
> Since EOD US time zone is deep-asleep-already time zone here, it
> would be
> swell if you could also please make sure not to leave php-shindig
> broken for
> a few hours :)
>
> Thanks!
>
> -- Chris
>
>
> On Mon, Feb 23, 2009 at 9:28 PM, Paul Lindner <pl...@hi5.com>
> wrote:
>
>> Okay, if no objections by EOD I will execute the changes referenced
>> in
>> SHINDIG-806..
>>
>>
>>
>> On Feb 23, 2009, at 12:26 PM, Louis Ryan wrote:
>>
>> +10000
>>>
>>> On Mon, Feb 23, 2009 at 12:20 PM, Paul Lindner <pl...@hi5.com>
>>> wrote:
>>>
>>> There's already an issue for this:
>>>>
>>>> https://issues.apache.org/jira/browse/SHINDIG-806
>>>>
>>>> I'm okay with this just so long as it's done with proper svn mv
>>>> commands.
>>>>
>>>>
>>>>
>>>> On Feb 23, 2009, at 12:13 PM, Vincent Siveton wrote:
>>>>
>>>> +1
>>>>
>>>>>
>>>>> Vincent
>>>>>
>>>>> 2009/2/23, Adam Winer <aw...@google.com>:
>>>>>
>>>>> Any objections to creating a "/src" directory underneath "/
>>>>> features"
>>>>>> and putting all source in there? The lack of this level of
>>>>>> hierarchy
>>>>>> is causing havoc with Maven builds, e.g. my current drive
>>>>>> includes the
>>>>>> following directory structure:
>>>>>>
>>>>>>
>>>>>>
>>>>>> features/target//classes/features/target/classes/features/
>>>>>> target/classes/features/target/classes/features/target/classes/
>>>>>> features/target/classes/features/target/classes/features/target/
>>>>>> classes/features/target/classes/features/target/classes/
>>>>>> features/target/classes/features/target/classes/opensocial-
>>>>>> templates
>>>>>>
>>>>>> If anyone needs me to hold off, let me know.
>>>>>>
>>>>>>
>>>>>> -- Adam Winer
>>>>>>
>>>>>>
>>>>>>
>>>>
>>
Re: Add "src/" directory in features
Posted by Chris Chabot <ch...@google.com>.
Just so I don't mis-understand, this is just moving the entire structure
that is now under /features/* to /features/src/* right?
If that is indeed correct, then please also adjust php/config/container.php,
the line that reads:
'features_path' => realpath(dirname(__FILE__) . '/../../features') . '/',
to:
'features_path' => realpath(dirname(__FILE__) . '/../../features/src') .
'/',
Since EOD US time zone is deep-asleep-already time zone here, it would be
swell if you could also please make sure not to leave php-shindig broken for
a few hours :)
Thanks!
-- Chris
On Mon, Feb 23, 2009 at 9:28 PM, Paul Lindner <pl...@hi5.com> wrote:
> Okay, if no objections by EOD I will execute the changes referenced in
> SHINDIG-806..
>
>
>
> On Feb 23, 2009, at 12:26 PM, Louis Ryan wrote:
>
> +10000
>>
>> On Mon, Feb 23, 2009 at 12:20 PM, Paul Lindner <pl...@hi5.com> wrote:
>>
>> There's already an issue for this:
>>>
>>> https://issues.apache.org/jira/browse/SHINDIG-806
>>>
>>> I'm okay with this just so long as it's done with proper svn mv commands.
>>>
>>>
>>>
>>> On Feb 23, 2009, at 12:13 PM, Vincent Siveton wrote:
>>>
>>> +1
>>>
>>>>
>>>> Vincent
>>>>
>>>> 2009/2/23, Adam Winer <aw...@google.com>:
>>>>
>>>> Any objections to creating a "/src" directory underneath "/features"
>>>>> and putting all source in there? The lack of this level of hierarchy
>>>>> is causing havoc with Maven builds, e.g. my current drive includes the
>>>>> following directory structure:
>>>>>
>>>>>
>>>>>
>>>>> features/target//classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/opensocial-templates
>>>>>
>>>>> If anyone needs me to hold off, let me know.
>>>>>
>>>>>
>>>>> -- Adam Winer
>>>>>
>>>>>
>>>>>
>>>
>
Re: Add "src/" directory in features
Posted by Paul Lindner <pl...@hi5.com>.
Okay, if no objections by EOD I will execute the changes referenced in
SHINDIG-806..
On Feb 23, 2009, at 12:26 PM, Louis Ryan wrote:
> +10000
>
> On Mon, Feb 23, 2009 at 12:20 PM, Paul Lindner <pl...@hi5.com>
> wrote:
>
>> There's already an issue for this:
>>
>> https://issues.apache.org/jira/browse/SHINDIG-806
>>
>> I'm okay with this just so long as it's done with proper svn mv
>> commands.
>>
>>
>>
>> On Feb 23, 2009, at 12:13 PM, Vincent Siveton wrote:
>>
>> +1
>>>
>>> Vincent
>>>
>>> 2009/2/23, Adam Winer <aw...@google.com>:
>>>
>>>> Any objections to creating a "/src" directory underneath "/
>>>> features"
>>>> and putting all source in there? The lack of this level of
>>>> hierarchy
>>>> is causing havoc with Maven builds, e.g. my current drive
>>>> includes the
>>>> following directory structure:
>>>>
>>>>
>>>> features/target//classes/features/target/classes/features/target/
>>>> classes/features/target/classes/features/target/classes/features/
>>>> target/classes/features/target/classes/features/target/classes/
>>>> features/target/classes/features/target/classes/features/target/
>>>> classes/features/target/classes/opensocial-templates
>>>>
>>>> If anyone needs me to hold off, let me know.
>>>>
>>>>
>>>> -- Adam Winer
>>>>
>>>>
>>
Re: Add "src/" directory in features
Posted by Louis Ryan <lr...@google.com>.
+10000
On Mon, Feb 23, 2009 at 12:20 PM, Paul Lindner <pl...@hi5.com> wrote:
> There's already an issue for this:
>
> https://issues.apache.org/jira/browse/SHINDIG-806
>
> I'm okay with this just so long as it's done with proper svn mv commands.
>
>
>
> On Feb 23, 2009, at 12:13 PM, Vincent Siveton wrote:
>
> +1
>>
>> Vincent
>>
>> 2009/2/23, Adam Winer <aw...@google.com>:
>>
>>> Any objections to creating a "/src" directory underneath "/features"
>>> and putting all source in there? The lack of this level of hierarchy
>>> is causing havoc with Maven builds, e.g. my current drive includes the
>>> following directory structure:
>>>
>>>
>>> features/target//classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/opensocial-templates
>>>
>>> If anyone needs me to hold off, let me know.
>>>
>>>
>>> -- Adam Winer
>>>
>>>
>
Re: Add "src/" directory in features
Posted by Paul Lindner <pl...@hi5.com>.
There's already an issue for this:
https://issues.apache.org/jira/browse/SHINDIG-806
I'm okay with this just so long as it's done with proper svn mv
commands.
On Feb 23, 2009, at 12:13 PM, Vincent Siveton wrote:
> +1
>
> Vincent
>
> 2009/2/23, Adam Winer <aw...@google.com>:
>> Any objections to creating a "/src" directory underneath "/features"
>> and putting all source in there? The lack of this level of hierarchy
>> is causing havoc with Maven builds, e.g. my current drive includes
>> the
>> following directory structure:
>>
>> features/target//classes/features/target/classes/features/target/
>> classes/features/target/classes/features/target/classes/features/
>> target/classes/features/target/classes/features/target/classes/
>> features/target/classes/features/target/classes/features/target/
>> classes/features/target/classes/opensocial-templates
>>
>> If anyone needs me to hold off, let me know.
>>
>>
>> -- Adam Winer
>>
Re: Add "src/" directory in features
Posted by Vincent Siveton <vi...@gmail.com>.
+1
Vincent
2009/2/23, Adam Winer <aw...@google.com>:
> Any objections to creating a "/src" directory underneath "/features"
> and putting all source in there? The lack of this level of hierarchy
> is causing havoc with Maven builds, e.g. my current drive includes the
> following directory structure:
>
> features/target//classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/features/target/classes/opensocial-templates
>
> If anyone needs me to hold off, let me know.
>
>
> -- Adam Winer
>