[GitHub] [tomcat] markt-asf commented on issue #275: BZ 59203 - interrupt tomcat threads instead of stopping

[GitBox <gi...@apache.org>]

markt-asf commented on issue #275: BZ 59203 - interrupt tomcat threads instead of stopping
URL: https://github.com/apache/tomcat/pull/275#issuecomment-615904750
 
 
   Thanks for the PR.
   
   There are multiple different changes in this commit. It needs to be broken down into one commit for the changed described in the PR summary and one commit for each type of clean-up.
   
   The configuration option that controls this behaviour is called `clearReferencesStopThreads`. That makes no sense with this PR applied. However, the behaviour of stopping threads needs to be retained.
   
   Note there are multiple places where stop() is called. This PR addresses only one of them.
   
   It would be better to align the behaviour for Executor and non-Executor threads. i.e.:
   
   - interrupt
   - pause
   - stop if still running
   
   There was some debate whether there should be multiple iterations if interrupt/pause but I'm leaning towards not. We are dealing with broken web applications here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org