You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "emmenlau (via GitHub)" <gi...@apache.org> on 2023/10/11 14:45:05 UTC
[PR] lib/cpp/test/Security*Test.cpp: Fix the check for OpenSSL version macro [thrift]
emmenlau opened a new pull request, #2864:
URL: https://github.com/apache/thrift/pull/2864
This commit fixes the current build problem on MSVC (see i.e. https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/48238772/job/cyh9vdh0xsiadd01)
```
C:\projects\thrift\lib\cpp\test\SecurityFromBufferTest.cpp(202): error C2065: 'OPENSSL_VERSION_MAJOR': undeclared identifier [C:\projects\build\MSVC2017\x64\lib\cpp\test\SecurityFromBufferTest.vcxproj]
C:\projects\thrift\lib\cpp\test\SecurityTest.cpp(224): error C2065: 'OPENSSL_VERSION_MAJOR': undeclared identifier
```
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lib/cpp/test/Security*Test.cpp: Fix the check for OpenSSL version macro [thrift]
Posted by "emmenlau (via GitHub)" <gi...@apache.org>.
emmenlau merged PR #2864:
URL: https://github.com/apache/thrift/pull/2864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lib/cpp/test/Security*Test.cpp: Fix the check for OpenSSL version macro [thrift]
Posted by "emmenlau (via GitHub)" <gi...@apache.org>.
emmenlau commented on PR #2864:
URL: https://github.com/apache/thrift/pull/2864#issuecomment-1759080905
According to https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/48252307/job/acjss7apkwg7w8wg and https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/48252307/job/0u6aevdbkpv6s45a this PR fixes the build problem on MSVC, while not breaking other builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org