You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/15 01:13:56 UTC
[GitHub] [pulsar-client-go] zzzming opened a new pull request #441: [issue 438] reader.HasNext() returns true on empty topic
zzzming opened a new pull request #441:
URL: https://github.com/apache/pulsar-client-go/pull/441
Master Issue: #438 https://github.com/apache/pulsar-client-go/issues/438
### Motivation
Fix issue #438
Reader.HasNext() should return true on empty topic, leading to hangs.
### Modifications
It checks the last message on the broker with a valid Entry Id (non-negative).
### Verifying this change
Add a new test case for read.erHasNext() when the topic is empty. The test case is part of CI now.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
### Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] merlimat merged pull request #441: [issue 438] reader.HasNext() returns true on empty topic
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #441:
URL: https://github.com/apache/pulsar-client-go/pull/441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org