You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/02/22 06:27:11 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #24295: Fix migration job target jdbc url parameters changed in job configuration
sandynz opened a new pull request, #24295:
URL: https://github.com/apache/shardingsphere/pull/24295
Changes proposed in this pull request:
- Fix migration job target jdbc url changed. JdbcQueryPropertiesExtension will extend jdbc url parameters when job running, it's not necessary to change it in job configuration; once it's persisted in job cfg and there's imcompatible parameter, it's hard to update it.
- Improve migration job source initialization
- Extract createYamlJobConfiguration from createJobAndStart
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy merged pull request #24295: Fix migration job target jdbc url parameters changed in job configuration
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy merged PR #24295:
URL: https://github.com/apache/shardingsphere/pull/24295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24295: Fix migration job target jdbc url parameters changed in job configuration
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24295:
URL: https://github.com/apache/shardingsphere/pull/24295#issuecomment-1439525420
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24295?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24295](https://codecov.io/gh/apache/shardingsphere/pull/24295?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (79678b0) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c42e1a33f7d7718ade1aaa6391ab6ff3b94146c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c42e1a3) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 79678b0 differs from pull request most recent head a3a83af. Consider uploading reports for the commit a3a83af to get more accurate results
```diff
@@ Coverage Diff @@
## master #24295 +/- ##
============================================
- Coverage 49.97% 49.97% -0.01%
Complexity 1573 1573
============================================
Files 3253 3253
Lines 53440 53441 +1
Branches 9854 9854
============================================
Hits 26706 26706
- Misses 24365 24366 +1
Partials 2369 2369
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/scenario/migration/api/impl/MigrationJobAPI.java](https://codecov.io/gh/apache/shardingsphere/pull/24295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvc2NlbmFyaW8vbWlncmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL21pZ3JhdGlvbi9hcGkvaW1wbC9NaWdyYXRpb25Kb2JBUEkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org