You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2022/02/22 19:40:55 UTC

[incubator-nuttx] branch master updated: Garbage configuration setting in EFM32 code

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new 1ded8bb  Garbage configuration setting in EFM32 code
1ded8bb is described below

commit 1ded8bbabbe0b23e3242be17fb87d418966778b2
Author: Gregory Nutt <gn...@nuttx.org>
AuthorDate: Tue Feb 22 12:33:31 2022 -0600

    Garbage configuration setting in EFM32 code
    
    arch/arm/src/efm32/efm32_start.c:
    
          /* For the case of the separate user-/kernel-space build, perform whatever
           * platform specific initialization of the user memory is required.
          * Normally this just means initializing the user space .data and .bss
           * segments.
           */
    
        #ifdef CONFIG_NUTTX_KERNEL
          efm32_userspace();
          showprogress('E');
        #endif
    
    But there is no CONFIG_NUTTX_KERNEL configuration setting.  Comparing this to other architectures it is clear this should be
    
        #ifdef CONFIG_BUILD_PROTECTED
---
 arch/arm/src/efm32/efm32_start.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/src/efm32/efm32_start.c b/arch/arm/src/efm32/efm32_start.c
index eb9453d..2ff7e9b 100644
--- a/arch/arm/src/efm32/efm32_start.c
+++ b/arch/arm/src/efm32/efm32_start.c
@@ -259,7 +259,7 @@ void __start(void)
    * segments.
    */
 
-#ifdef CONFIG_NUTTX_KERNEL
+#ifdef CONFIG_BUILD_PROTECTED
   efm32_userspace();
   showprogress('E');
 #endif