You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Marc Spaggiari (JIRA)" <ji...@apache.org> on 2014/02/25 14:34:19 UTC
[jira] [Commented] (HBASE-10604) Fix parseArgs javadoc
[ https://issues.apache.org/jira/browse/HBASE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911566#comment-13911566 ]
Jean-Marc Spaggiari commented on HBASE-10604:
---------------------------------------------
Pach will come shortly. (later today)
> Fix parseArgs javadoc
> ---------------------
>
> Key: HBASE-10604
> URL: https://issues.apache.org/jira/browse/HBASE-10604
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Marc Spaggiari
> Assignee: Jean-Marc Spaggiari
> Priority: Minor
>
> Javadoc for parseArgs is a cut&past of previous method and need to be fixed.
> {code}
> /*
> * Adds a region's meta information from the passed <code>meta</code>
> * region.
> *
> * @param metainfo hbase:meta HRegionInfo to be updated
> * @param region HRegion to add to <code>meta</code>
> *
> * @throws IOException
> */
> private int parseArgs(String[] args) throws IOException {
> GenericOptionsParser parser =
> new GenericOptionsParser(getConf(), args);
> String[] remainingArgs = parser.getRemainingArgs();
> if (remainingArgs.length != 3) {
> usage();
> return -1;
> }
> tableName = TableName.valueOf(remainingArgs[0]);
> region1 = Bytes.toBytesBinary(remainingArgs[1]);
> region2 = Bytes.toBytesBinary(remainingArgs[2]);
> int status = 0;
> if (notInTable(tableName, region1) || notInTable(tableName, region2)) {
> status = -1;
> } else if (Bytes.equals(region1, region2)) {
> LOG.error("Can't merge a region with itself");
> status = -1;
> }
> return status;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)