You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "James E. King III (JIRA)" <ji...@apache.org> on 2019/03/25 12:34:00 UTC

[jira] [Commented] (THRIFT-4838) Swift TSocketTransport implementation is missing unix domain socket support

    [ https://issues.apache.org/jira/browse/THRIFT-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800639#comment-16800639 ] 

James E. King III commented on THRIFT-4838:
-------------------------------------------

THRIFT-4547 should be done first, if possible.

> Swift TSocketTransport implementation is missing unix domain socket support
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-4838
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4838
>             Project: Thrift
>          Issue Type: Bug
>          Components: Swift - Library
>            Reporter: Kevin Wojniak
>            Priority: Major
>
> TSocketTransport in Objective-C supports initWithPath: for unix domain sockets:
> [https://github.com/apache/thrift/blob/f3ec277e7e2c147342831ecec590bc2f71b07761/lib/cocoa/src/transport/TSocketTransport.m#L82]
> However since the Objective-C implementation has been removed in 0.13, the Swift version does not implement this:
> https://github.com/apache/thrift/blob/master/lib/swift/Sources/TSocketTransport.swift
> Before this is done I think TCFSocketTransport should be moved to its own file. This would avoid extra #if logic to prevent Linux compiling, and simplify the code.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)