You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2020/01/09 03:02:42 UTC
[GitHub] [bigtop] guyuqi opened a new pull request #577: BIGTOP-3236:
Zeppelin smoke tests implementation
guyuqi opened a new pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577
The Smoke tests deployment by provisioner would be broken due to BIGTOP-2742, but actually zeppelin server has been started.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] guyuqi commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
guyuqi commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r392810563
##########
File path: bigtop-tests/smoke-tests/zeppelin/TestZeppelinSmoke.groovy
##########
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.BeforeClass
+import org.junit.AfterClass
+import org.apache.bigtop.itest.shell.Shell
+import static org.junit.Assert.assertNotNull
+import static org.junit.Assert.assertTrue
+import org.junit.Test
+import org.apache.bigtop.itest.JarContent
+import org.apache.bigtop.itest.TestUtils
+import org.junit.runner.RunWith
+import org.apache.bigtop.itest.shell.Shell
+import static org.apache.bigtop.itest.LogErrorsUtils.logError
+import static org.junit.Assert.assertTrue
+
+class TestZeppelinSmoke {
+ static Shell sh = new Shell("/bin/bash -s");
+
+ private static String ZEPPELIN_HOME = System.getenv("ZEPPELIN_HOME");
+
+ /* Align with the version defined in bigtop.bom*/
+ private static String ZEPPELIN_VERSION = "0.7.3";
+
+ @Test
+ public void InstallIntperTest() {
+ sh.exec(ZEPPELIN_HOME
+ + "/bin/install-interpreter.sh "
+ + "--name shell --artifact org.apache.zeppelin:zeppelin-shell:${ZEPPELIN_VERSION}"
Review comment:
Agreed and let me refine it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] guyuqi commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
guyuqi commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r376998853
##########
File path: bigtop-tests/smoke-tests/zeppelin/TestZeppelinSmoke.groovy
##########
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.BeforeClass
+import org.junit.AfterClass
+import org.apache.bigtop.itest.shell.Shell
+import static org.junit.Assert.assertNotNull
+import static org.junit.Assert.assertTrue
+import org.junit.Test
+import org.apache.bigtop.itest.JarContent
+import org.apache.bigtop.itest.TestUtils
+import org.junit.runner.RunWith
+import org.apache.bigtop.itest.shell.Shell
+import static org.apache.bigtop.itest.LogErrorsUtils.logError
+import static org.junit.Assert.assertTrue
+
+class TestZeppelinSmoke {
+ static Shell sh = new Shell("/bin/bash -s");
+
+ static final String ZEPPELIN_HOME = System.getenv("ZEPPELIN_HOME");
+
+ @Test
+ public void InstallIntperTest() {
+ sh.exec(ZEPPELIN_HOME
+ + "/bin/install-interpreter.sh "
+ + "--name shell --artifact org.apache.zeppelin:zeppelin-shell:0.7.3"
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r376793894
##########
File path: provisioner/utils/setup-env-debian.sh
##########
@@ -24,6 +24,8 @@ apt-get -y install rng-tools
sed -i.bak 's@#HRNGDEVICE=/dev/null@HRNGDEVICE=/dev/urandom@' /etc/default/rng-tools
service rng-tools start
+apt-get install -y locales
Review comment:
Got it. So let's just add a comment here to reveal your finding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r392778248
##########
File path: bigtop-tests/smoke-tests/zeppelin/TestZeppelinSmoke.groovy
##########
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.BeforeClass
+import org.junit.AfterClass
+import org.apache.bigtop.itest.shell.Shell
+import static org.junit.Assert.assertNotNull
+import static org.junit.Assert.assertTrue
+import org.junit.Test
+import org.apache.bigtop.itest.JarContent
+import org.apache.bigtop.itest.TestUtils
+import org.junit.runner.RunWith
+import org.apache.bigtop.itest.shell.Shell
+import static org.apache.bigtop.itest.LogErrorsUtils.logError
+import static org.junit.Assert.assertTrue
+
+class TestZeppelinSmoke {
+ static Shell sh = new Shell("/bin/bash -s");
+
+ private static String ZEPPELIN_HOME = System.getenv("ZEPPELIN_HOME");
+
+ /* Align with the version defined in bigtop.bom*/
+ private static String ZEPPELIN_VERSION = "0.7.3";
+
+ @Test
+ public void InstallIntperTest() {
+ sh.exec(ZEPPELIN_HOME
+ + "/bin/install-interpreter.sh "
+ + "--name shell --artifact org.apache.zeppelin:zeppelin-shell:${ZEPPELIN_VERSION}"
Review comment:
So the wildcard does not work here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r373865773
##########
File path: provisioner/utils/setup-env-debian.sh
##########
@@ -24,6 +24,8 @@ apt-get -y install rng-tools
sed -i.bak 's@#HRNGDEVICE=/dev/null@HRNGDEVICE=/dev/urandom@' /etc/default/rng-tools
service rng-tools start
+apt-get install -y locales
Review comment:
How about we add a comment for the reason why we need to install this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] guyuqi commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
guyuqi commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r376998817
##########
File path: provisioner/utils/setup-env-debian.sh
##########
@@ -24,6 +24,8 @@ apt-get -y install rng-tools
sed -i.bak 's@#HRNGDEVICE=/dev/null@HRNGDEVICE=/dev/urandom@' /etc/default/rng-tools
service rng-tools start
+apt-get install -y locales
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye commented on issue #577: BIGTOP-3236: Zeppelin
smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye commented on issue #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#issuecomment-573350034
Looks good. Let me test this as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] guyuqi commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
guyuqi commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r376212316
##########
File path: provisioner/utils/setup-env-debian.sh
##########
@@ -24,6 +24,8 @@ apt-get -y install rng-tools
sed -i.bak 's@#HRNGDEVICE=/dev/null@HRNGDEVICE=/dev/urandom@' /etc/default/rng-tools
service rng-tools start
+apt-get install -y locales
Review comment:
The testing process would be broken due to "No such file or derictory: /etc/default/locale" in ubuntu16.04.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye edited a comment on issue #577: BIGTOP-3236:
Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye edited a comment on issue #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#issuecomment-573350034
Looks good. Let me test this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] guyuqi commented on issue #577: BIGTOP-3236: Zeppelin
smoke tests implementation
Posted by GitBox <gi...@apache.org>.
guyuqi commented on issue #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#issuecomment-599161819
> This one conflict with the codebase. Could you rebase @guyuqi ?
Rebased, thanks. @evans-ye
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye commented on issue #577: BIGTOP-3236: Zeppelin
smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye commented on issue #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#issuecomment-599092474
This one conflict with the codebase. Could you rebase @guyuqi ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r376793894
##########
File path: provisioner/utils/setup-env-debian.sh
##########
@@ -24,6 +24,8 @@ apt-get -y install rng-tools
sed -i.bak 's@#HRNGDEVICE=/dev/null@HRNGDEVICE=/dev/urandom@' /etc/default/rng-tools
service rng-tools start
+apt-get install -y locales
Review comment:
Got it. So let's just add a comment to reveal your finding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r392778248
##########
File path: bigtop-tests/smoke-tests/zeppelin/TestZeppelinSmoke.groovy
##########
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.BeforeClass
+import org.junit.AfterClass
+import org.apache.bigtop.itest.shell.Shell
+import static org.junit.Assert.assertNotNull
+import static org.junit.Assert.assertTrue
+import org.junit.Test
+import org.apache.bigtop.itest.JarContent
+import org.apache.bigtop.itest.TestUtils
+import org.junit.runner.RunWith
+import org.apache.bigtop.itest.shell.Shell
+import static org.apache.bigtop.itest.LogErrorsUtils.logError
+import static org.junit.Assert.assertTrue
+
+class TestZeppelinSmoke {
+ static Shell sh = new Shell("/bin/bash -s");
+
+ private static String ZEPPELIN_HOME = System.getenv("ZEPPELIN_HOME");
+
+ /* Align with the version defined in bigtop.bom*/
+ private static String ZEPPELIN_VERSION = "0.7.3";
+
+ @Test
+ public void InstallIntperTest() {
+ sh.exec(ZEPPELIN_HOME
+ + "/bin/install-interpreter.sh "
+ + "--name shell --artifact org.apache.zeppelin:zeppelin-shell:${ZEPPELIN_VERSION}"
Review comment:
@guyuqi
So the wildcard does not work here? I can imaging that for future Zeppelin upgrade we'll forget to update the version here ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r392778248
##########
File path: bigtop-tests/smoke-tests/zeppelin/TestZeppelinSmoke.groovy
##########
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.BeforeClass
+import org.junit.AfterClass
+import org.apache.bigtop.itest.shell.Shell
+import static org.junit.Assert.assertNotNull
+import static org.junit.Assert.assertTrue
+import org.junit.Test
+import org.apache.bigtop.itest.JarContent
+import org.apache.bigtop.itest.TestUtils
+import org.junit.runner.RunWith
+import org.apache.bigtop.itest.shell.Shell
+import static org.apache.bigtop.itest.LogErrorsUtils.logError
+import static org.junit.Assert.assertTrue
+
+class TestZeppelinSmoke {
+ static Shell sh = new Shell("/bin/bash -s");
+
+ private static String ZEPPELIN_HOME = System.getenv("ZEPPELIN_HOME");
+
+ /* Align with the version defined in bigtop.bom*/
+ private static String ZEPPELIN_VERSION = "0.7.3";
+
+ @Test
+ public void InstallIntperTest() {
+ sh.exec(ZEPPELIN_HOME
+ + "/bin/install-interpreter.sh "
+ + "--name shell --artifact org.apache.zeppelin:zeppelin-shell:${ZEPPELIN_VERSION}"
Review comment:
So the wildcard does not work here? I can iamaging that for future Zeppelin upgrade we'll forget to update the version here ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bigtop] evans-ye commented on a change in pull request #577:
BIGTOP-3236: Zeppelin smoke tests implementation
Posted by GitBox <gi...@apache.org>.
evans-ye commented on a change in pull request #577: BIGTOP-3236: Zeppelin smoke tests implementation
URL: https://github.com/apache/bigtop/pull/577#discussion_r373865651
##########
File path: bigtop-tests/smoke-tests/zeppelin/TestZeppelinSmoke.groovy
##########
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.BeforeClass
+import org.junit.AfterClass
+import org.apache.bigtop.itest.shell.Shell
+import static org.junit.Assert.assertNotNull
+import static org.junit.Assert.assertTrue
+import org.junit.Test
+import org.apache.bigtop.itest.JarContent
+import org.apache.bigtop.itest.TestUtils
+import org.junit.runner.RunWith
+import org.apache.bigtop.itest.shell.Shell
+import static org.apache.bigtop.itest.LogErrorsUtils.logError
+import static org.junit.Assert.assertTrue
+
+class TestZeppelinSmoke {
+ static Shell sh = new Shell("/bin/bash -s");
+
+ static final String ZEPPELIN_HOME = System.getenv("ZEPPELIN_HOME");
+
+ @Test
+ public void InstallIntperTest() {
+ sh.exec(ZEPPELIN_HOME
+ + "/bin/install-interpreter.sh "
+ + "--name shell --artifact org.apache.zeppelin:zeppelin-shell:0.7.3"
Review comment:
Same here if we can't make the version *. At least we can make it configurable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services