You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/05/20 13:39:16 UTC
[commons-geometry] 03/16: GEOMETRY-29 corrects comment for copy
factory method,
corrects typo. Removes factory method with all arguments supplied.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git
commit b17f640f95daf4ca19f39df5af7987bdf3ab574c
Author: Sven Rathgeber <sv...@dfs.de>
AuthorDate: Mon Mar 18 07:40:11 2019 +0100
GEOMETRY-29 corrects comment for copy factory method, corrects typo. Removes factory method with all arguments supplied.
---
.../apache/commons/geometry/euclidean/threed/Plane.java | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java
index f581dc1..aea5b16 100644
--- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java
+++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Plane.java
@@ -90,16 +90,6 @@ public final class Plane implements Hyperplane<Vector3D>, Embedding<Vector3D, Ve
return new Plane(u, v, w, origin, originOffset, precision);
}
- // TODO check this one
- public static Plane of(Vector3D u, Vector3D v, Vector3D w, Vector3D origin, double originOffset,
- DoublePrecisionContext precision) {
- if (!w.orthogonal().equals(u, precision))
- {
- throw new IllegalArgumentException("w must be orthogonal to u.");
- }
- return new Plane(u, v, w, origin, originOffset, precision);
- }
-
/**
* Build a plane from three points.
* <p>
@@ -118,7 +108,7 @@ public final class Plane implements Hyperplane<Vector3D>, Embedding<Vector3D, Ve
}
/**
- * Copy constructor.
+ * Copy plane.
* <p>
* The instance created is completely independent of the original one. A deep
* copy is used, none of the underlying object are shared.
@@ -186,7 +176,7 @@ public final class Plane implements Hyperplane<Vector3D>, Embedding<Vector3D, Ve
* Get the normalized normal vector.
* <p>
* The frame defined by ({@link #getU getU}, {@link #getV getV},
- * {@link #getNormal getNormal}) is a rigth-handed orthonormalized frame).
+ * {@link #getNormal getNormal}) is a right-handed orthonormalized frame).
* </p>
*
* @return normalized normal vector