You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by br...@apache.org on 2013/06/12 16:03:00 UTC
svn commit: r1492211 -
/subversion/trunk/tools/server-side/svnpubsub/svnpubsub/client.py
Author: breser
Date: Wed Jun 12 14:03:00 2013
New Revision: 1492211
URL: http://svn.apache.org/r1492211
Log:
Revert r1492189, this isn't nearly enough to enable https support.
Modified:
subversion/trunk/tools/server-side/svnpubsub/svnpubsub/client.py
Modified: subversion/trunk/tools/server-side/svnpubsub/svnpubsub/client.py
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/server-side/svnpubsub/svnpubsub/client.py?rev=1492211&r1=1492210&r2=1492211&view=diff
==============================================================================
--- subversion/trunk/tools/server-side/svnpubsub/svnpubsub/client.py (original)
+++ subversion/trunk/tools/server-side/svnpubsub/svnpubsub/client.py Wed Jun 12 14:03:00 2013
@@ -71,8 +71,8 @@ class Client(asynchat.async_chat):
self.url = url
parsed_url = urlparse.urlsplit(url)
- if parsed_url.scheme != 'http' and parsed.url_scheme != 'https':
- raise ValueError("URL scheme must be http or https: '%s'" % url)
+ if parsed_url.scheme != 'http':
+ raise ValueError("URL scheme must be http: '%s'" % url)
host = parsed_url.hostname
port = parsed_url.port
resource = parsed_url.path
Re: svn commit: r1492211 - /subversion/trunk/tools/server-side/svnpubsub/svnpubsub/client.py
Posted by Ben Reser <be...@reser.org>.
On Wed, Jun 12, 2013 at 5:03 PM, Greg Stein <gs...@gmail.com> wrote:
> Yeah... I don't think asyncore can really handle SSL sockets. But
> maybe using ssl.wrap_socket() could make it work. Override
> create_socket(), provide some more params, etc.
Client should probably support https even if server can't (yet)
because you can proxy the server through something like Apache httpd
to get SSL support. In fact I'd expect places to do this in order to
put it on their preferred endpoint.
Re: svn commit: r1492211 - /subversion/trunk/tools/server-side/svnpubsub/svnpubsub/client.py
Posted by Greg Stein <gs...@gmail.com>.
On Wed, Jun 12, 2013 at 10:03 AM, <br...@apache.org> wrote:
> Author: breser
> Date: Wed Jun 12 14:03:00 2013
> New Revision: 1492211
>
> URL: http://svn.apache.org/r1492211
> Log:
> Revert r1492189, this isn't nearly enough to enable https support.
Yeah... I don't think asyncore can really handle SSL sockets. But
maybe using ssl.wrap_socket() could make it work. Override
create_socket(), provide some more params, etc.
Cheers,
-g