You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2011/10/24 18:34:36 UTC

svn commit: r1188210 - /tapestry/tapestry5/trunk/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java

Author: hlship
Date: Mon Oct 24 16:34:36 2011
New Revision: 1188210

URL: http://svn.apache.org/viewvc?rev=1188210&view=rev
Log:
Update some out-of-date comments

Modified:
    tapestry/tapestry5/trunk/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java

Modified: tapestry/tapestry5/trunk/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java?rev=1188210&r1=1188209&r2=1188210&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java (original)
+++ tapestry/tapestry5/trunk/plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java Mon Oct 24 16:34:36 2011
@@ -962,8 +962,9 @@ public class PlasticClassImpl extends Lo
         {
             instanceContextFieldName = makeUnique(fieldNames, "instanceContext");
 
-            // TODO: Once we support inheritance, we could use a protected field and only initialize
-            // it once, in the first base class where it is needed.
+            // TODO: We could use a protected field and only initialize
+            // it once, in the first base class where it is needed, though that raises the possibilities
+            // of name conflicts (a subclass might introduce a field with a conflicting name).
 
             FieldNode node = new FieldNode(ACC_PRIVATE | ACC_FINAL, instanceContextFieldName, INSTANCE_CONTEXT_DESC,
                     null, null);