You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "kevinrr888 (via GitHub)" <gi...@apache.org> on 2025/11/25 18:37:27 UTC

[PR] Improves log messages for AcceptableException [accumulo]

kevinrr888 opened a new pull request, #5992:
URL: https://github.com/apache/accumulo/pull/5992

   AcceptableExceptions logged now additionally include the table operation, the exception type, and now always include a non-null description.
   
   closes #5977


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves log messages for AcceptableException [accumulo]

Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 commented on PR #5992:
URL: https://github.com/apache/accumulo/pull/5992#issuecomment-3577058590

   Example of trying to compact an offline table:
   before:
   ```
   [fate.Fate] DEBUG: Failed to execute Repo FATE[34104f983aca23f4] for null(1) null
   ```
   
   after:
   ```
   [fate.Fate] DEBUG: Failed to execute Repo FATE[59879a0729fa37b6] for null(1) op:COMPACT exception-type:OFFLINE desc:Table is offline
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves log messages for AcceptableException [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5992:
URL: https://github.com/apache/accumulo/pull/5992#discussion_r2561362929


##########
core/src/main/java/org/apache/accumulo/core/fate/Fate.java:
##########
@@ -174,7 +174,8 @@ private void transitionToFailed(long tid, Exception e) {
       // as a warning. They're a normal, handled failure condition.
       if (e instanceof AcceptableException) {
         var tableOpEx = (AcceptableThriftTableOperationException) e;
-        log.debug(msg + " for {}({}) {}", tableOpEx.getTableName(), tableOpEx.getTableId(),
+        log.debug(msg + " for {}({}) op:{} exception-type:{} desc:{}", tableOpEx.getTableName(),

Review Comment:
   Could avoid the string concat and pass
   ```suggestion
           log.debug("{} for {}({}) op:{} exception-type:{} desc:{}",msg,  tableOpEx.getTableName(),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves log messages for AcceptableException [accumulo]

Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 merged PR #5992:
URL: https://github.com/apache/accumulo/pull/5992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org