[GitHub] [beam] daria-malkova commented on a change in pull request #16118: [BEAM-13362][Playground] python ci cd support options + yapf/linter fix

[GitBox <gi...@apache.org>]

daria-malkova commented on a change in pull request #16118:
URL: https://github.com/apache/beam/pull/16118#discussion_r761956640



##########
File path: playground/infrastructure/helper.py
##########
@@ -236,14 +238,20 @@ def _validate(tag: dict, supported_categories: List[str]) -> bool:
   """
   valid = True
   for field in fields(TagFields):
-    if tag.get(field.default) is None:
+    if field.default not in tag:
       logging.error(
         "tag doesn't contain %s field: %s \n"
         "Please, check that this field exists in the beam playground tag."
         "If you are sure that this field exists in the tag"
         " check the format of indenting.", field.default, tag.__str__())
       valid = False
 
+    name = tag.get(TagFields.NAME)
+    if name == '':
+        logging.error("tag's field name is incorrect: " + tag.__str__() + "\n" +
+                      "name can not be empty.")
+        valid = False

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org