You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/12 07:47:36 UTC
[GitHub] [doris] BePPPower opened a new pull request, #15862: [feature](multi-catalog) support oracle jdbc catalog
BePPPower opened a new pull request, #15862:
URL: https://github.com/apache/doris/pull/15862
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [x] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15862: [feature](multi-catalog) support oracle jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15862:
URL: https://github.com/apache/doris/pull/15862#issuecomment-1381562492
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BePPPower commented on a diff in pull request #15862: [feature](multi-catalog) support oracle jdbc catalog
Posted by GitBox <gi...@apache.org>.
BePPPower commented on code in PR #15862:
URL: https://github.com/apache/doris/pull/15862#discussion_r1068979288
##########
fe/fe-core/src/main/java/org/apache/doris/external/jdbc/JdbcClient.java:
##########
@@ -563,6 +563,65 @@ public Type clickhouseTypeToDoris(JdbcFieldSchema fieldSchema) {
// Todo(zyk): Wait the JDBC external table support the array type then supported clickhouse array type
}
+ public Type oracleTypeToDoris(JdbcFieldSchema fieldSchema) {
+ String oracleType = fieldSchema.getDataTypeName();
+ if (oracleType.startsWith("INTERVAL")) {
+ oracleType = oracleType.substring(0, 8);
+ }
+ switch (oracleType) {
+ case "NUMBER":
+ int precision = fieldSchema.getColumnSize();
+ int scale = fieldSchema.getDecimalDigits();
+ if (scale == 0) {
+ if (precision < 3) {
+ return Type.TINYINT;
+ } else if (precision < 5) {
+ return Type.SMALLINT;
+ } else if (precision < 10) {
+ return Type.INT;
+ } else if (precision < 19) {
+ return Type.BIGINT;
+ } else if (precision < 39) {
+ return Type.LARGEINT;
+ }
+ return ScalarType.createStringType();
+ }
+ if (precision <= ScalarType.MAX_DECIMAL128_PRECISION) {
+ if (!Config.enable_decimal_conversion && precision > ScalarType.MAX_DECIMALV2_PRECISION) {
+ return ScalarType.createStringType();
+ }
+ return ScalarType.createDecimalType(precision, scale);
+ } else {
+ return ScalarType.createStringType();
+ }
+ case "FLOAT":
+ return Type.DOUBLE;
+ case "VARCHAR2":
+ case "NVARCHAR2":
+ ScalarType varcharType = ScalarType.createVarcharType(fieldSchema.columnSize);
+ return varcharType;
+ case "CHAR":
+ case "NCHAR":
+ ScalarType charType = ScalarType.createCharType(fieldSchema.columnSize);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15862: [feature](multi-catalog) support oracle jdbc catalog
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15862:
URL: https://github.com/apache/doris/pull/15862#issuecomment-1380197082
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.27 seconds
load time: 488 seconds
storage size: 17123040156 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230112113516_clickbench_pr_78613.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15862: [feature](multi-catalog) support oracle jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15862:
URL: https://github.com/apache/doris/pull/15862#issuecomment-1381562374
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15862: [feature](multi-catalog) support oracle jdbc catalog
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #15862:
URL: https://github.com/apache/doris/pull/15862#discussion_r1068897375
##########
fe/fe-core/src/main/java/org/apache/doris/external/jdbc/JdbcClient.java:
##########
@@ -563,6 +563,65 @@ public Type clickhouseTypeToDoris(JdbcFieldSchema fieldSchema) {
// Todo(zyk): Wait the JDBC external table support the array type then supported clickhouse array type
}
+ public Type oracleTypeToDoris(JdbcFieldSchema fieldSchema) {
+ String oracleType = fieldSchema.getDataTypeName();
+ if (oracleType.startsWith("INTERVAL")) {
+ oracleType = oracleType.substring(0, 8);
+ }
+ switch (oracleType) {
+ case "NUMBER":
+ int precision = fieldSchema.getColumnSize();
+ int scale = fieldSchema.getDecimalDigits();
+ if (scale == 0) {
+ if (precision < 3) {
+ return Type.TINYINT;
+ } else if (precision < 5) {
+ return Type.SMALLINT;
+ } else if (precision < 10) {
+ return Type.INT;
+ } else if (precision < 19) {
+ return Type.BIGINT;
+ } else if (precision < 39) {
+ return Type.LARGEINT;
+ }
+ return ScalarType.createStringType();
+ }
+ if (precision <= ScalarType.MAX_DECIMAL128_PRECISION) {
+ if (!Config.enable_decimal_conversion && precision > ScalarType.MAX_DECIMALV2_PRECISION) {
+ return ScalarType.createStringType();
+ }
+ return ScalarType.createDecimalType(precision, scale);
+ } else {
+ return ScalarType.createStringType();
+ }
+ case "FLOAT":
+ return Type.DOUBLE;
+ case "VARCHAR2":
+ case "NVARCHAR2":
+ ScalarType varcharType = ScalarType.createVarcharType(fieldSchema.columnSize);
+ return varcharType;
+ case "CHAR":
+ case "NCHAR":
+ ScalarType charType = ScalarType.createCharType(fieldSchema.columnSize);
Review Comment:
Use String for all `char` and `varchar`, because the size of char/varchar in oracle maybe "char length", but in Doris, it is "byte length". For Chinese word, one Chinese word is 1 char length but 3 byte length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15862: [feature](multi-catalog) support oracle jdbc catalog
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15862:
URL: https://github.com/apache/doris/pull/15862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org