You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2017/10/30 10:37:36 UTC

[GitHub] spark pull request #19532: [CORE]Modify the duration real-time calculation a...

Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19532#discussion_r147665765
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
    @@ -120,7 +120,7 @@ private[spark] class SparkUI private (
             attemptId = None,
             startTime = new Date(startTime),
             endTime = new Date(-1),
    -        duration = 0,
    +        duration = System.currentTimeMillis() - startTime,
    --- End diff --
    
    I'm neutral to this change. Normally we don't update the duration until the attempt has been finished. But you can also argue that we do in other places.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org