[GitHub] [geode] mivanac commented on a change in pull request #5630: GEODE-8605: Alter Gateway Sender command

[GitBox <gi...@apache.org>]

mivanac commented on a change in pull request #5630:
URL: https://github.com/apache/geode/pull/5630#discussion_r604209746



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAttributes.java
##########
@@ -31,63 +31,201 @@
   public static final boolean DEFAULT_IS_META_QUEUE = false;
 
 
-  public int socketBufferSize = GatewaySender.DEFAULT_SOCKET_BUFFER_SIZE;
+  private int socketBufferSize = GatewaySender.DEFAULT_SOCKET_BUFFER_SIZE;
 
-  public int socketReadTimeout = GatewaySender.DEFAULT_SOCKET_READ_TIMEOUT;
+  private int socketReadTimeout = GatewaySender.DEFAULT_SOCKET_READ_TIMEOUT;
 
-  public int maximumQueueMemory = GatewaySender.DEFAULT_MAXIMUM_QUEUE_MEMORY;
+  private int maximumQueueMemory = GatewaySender.DEFAULT_MAXIMUM_QUEUE_MEMORY;
 
-  public int batchSize = GatewaySender.DEFAULT_BATCH_SIZE;
+  private int batchSize = GatewaySender.DEFAULT_BATCH_SIZE;
 
-  public int batchTimeInterval = GatewaySender.DEFAULT_BATCH_TIME_INTERVAL;
+  private int batchTimeInterval = GatewaySender.DEFAULT_BATCH_TIME_INTERVAL;
 
-  public boolean isBatchConflationEnabled = GatewaySender.DEFAULT_BATCH_CONFLATION;
+  private boolean isBatchConflationEnabled = GatewaySender.DEFAULT_BATCH_CONFLATION;
 
-  public boolean isPersistenceEnabled = GatewaySender.DEFAULT_PERSISTENCE_ENABLED;
+  private boolean isPersistenceEnabled = GatewaySender.DEFAULT_PERSISTENCE_ENABLED;
 
-  public int alertThreshold = GatewaySender.DEFAULT_ALERT_THRESHOLD;
+  private int alertThreshold = GatewaySender.DEFAULT_ALERT_THRESHOLD;
 
-  public boolean manualStart = GatewaySender.DEFAULT_MANUAL_START;
+  private boolean manualStart = GatewaySender.DEFAULT_MANUAL_START;
 
-  public String diskStoreName;
+  private String diskStoreName;
 
-  public List<GatewayEventFilter> eventFilters = new ArrayList<GatewayEventFilter>();
+  private List<GatewayEventFilter> eventFilters = new ArrayList<GatewayEventFilter>();
 
-  public ArrayList<GatewayTransportFilter> transFilters = new ArrayList<GatewayTransportFilter>();
+  private ArrayList<GatewayTransportFilter> transFilters = new ArrayList<GatewayTransportFilter>();
 
-  public List<AsyncEventListener> listeners = new ArrayList<AsyncEventListener>();
+  private List<AsyncEventListener> listeners = new ArrayList<AsyncEventListener>();
 
-  public GatewayEventSubstitutionFilter eventSubstitutionFilter;
+  private GatewayEventSubstitutionFilter eventSubstitutionFilter;
 
-  public String id;
+  private String id;
 
-  public int remoteDs = GatewaySender.DEFAULT_DISTRIBUTED_SYSTEM_ID;
+  private int remoteDs = GatewaySender.DEFAULT_DISTRIBUTED_SYSTEM_ID;
 
-  public LocatorDiscoveryCallback locatorDiscoveryCallback;
+  private LocatorDiscoveryCallback locatorDiscoveryCallback;
 
-  public boolean isDiskSynchronous = GatewaySender.DEFAULT_DISK_SYNCHRONOUS;
+  private boolean isDiskSynchronous = GatewaySender.DEFAULT_DISK_SYNCHRONOUS;
 
-  public OrderPolicy policy;
+  private OrderPolicy policy;
 
-  public int dispatcherThreads = GatewaySender.DEFAULT_DISPATCHER_THREADS;
+  private int dispatcherThreads = GatewaySender.DEFAULT_DISPATCHER_THREADS;
 
-  public int parallelism = GatewaySender.DEFAULT_PARALLELISM_REPLICATED_REGION;
+  private int parallelism = GatewaySender.DEFAULT_PARALLELISM_REPLICATED_REGION;
 
-  public boolean isParallel = GatewaySender.DEFAULT_IS_PARALLEL;
+  private boolean isParallel = GatewaySender.DEFAULT_IS_PARALLEL;
 
-  public boolean groupTransactionEvents = GatewaySender.DEFAULT_MUST_GROUP_TRANSACTION_EVENTS;
+  private boolean groupTransactionEvents = GatewaySender.DEFAULT_MUST_GROUP_TRANSACTION_EVENTS;
 
-  public boolean isForInternalUse = GatewaySender.DEFAULT_IS_FOR_INTERNAL_USE;
+  private boolean isForInternalUse = GatewaySender.DEFAULT_IS_FOR_INTERNAL_USE;
 
-  public boolean isBucketSorted = GatewaySenderAttributes.DEFAULT_IS_BUCKETSORTED;
+  private boolean isBucketSorted = GatewaySenderAttributes.DEFAULT_IS_BUCKETSORTED;
 
-  public boolean isMetaQueue = GatewaySenderAttributes.DEFAULT_IS_META_QUEUE;
+  private boolean isMetaQueue = GatewaySenderAttributes.DEFAULT_IS_META_QUEUE;
 
-  public boolean forwardExpirationDestroy = GatewaySender.DEFAULT_FORWARD_EXPIRATION_DESTROY;
+  private boolean forwardExpirationDestroy = GatewaySender.DEFAULT_FORWARD_EXPIRATION_DESTROY;
 
-  public boolean enforceThreadsConnectSameReceiver =
+  private boolean enforceThreadsConnectSameReceiver =
       GatewaySender.DEFAULT_ENFORCE_THREADS_CONNECT_SAME_RECEIVER;
 
+  // Added due to "alter gateway-sender" command
+
+  private boolean modifyAlertThreshold = false;
+
+  private boolean modifyBatchSize = false;
+
+  private boolean modifyBatchTimeInterval = false;
+
+  private boolean modifyGroupTransactionEvents = false;
+
+  private boolean modifyGatewayEventFilter = false;
+
+  private boolean modifyGatewayTransportFilter = false;

Review comment:
       Thanks for comments. This is not needed, since it was part of previous solution. I will remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org