[testing] Swing tests clean up

["Ivanov, Alexey A" <al...@intel.com>]

Nathan,

 

Do you thing empty lines in tests are useless? Why have you removed
every single empty line in tests?

They were there on purpose! They separate parts of a unit test. I don't
want them to be dropped! The code is unreadable without them.

 

Thank you in advance,

Alexey.

 

--
Alexey A. Ivanov
Intel Enterprise Solutions Software Division

 

Re: [testing] Swing tests clean up

[Nathan Beyer <nb...@gmail.com>]

Sorry. I guess my formatting was over aggressive while eliminating the
compiler warnings. Note, not EVERY empty line was eliminated, just
those within methods. I actually added a number of lines between
methods, classes, etc.

Personal, I didn't think that the tests are any less readable. I would
argue that if a test method needs to be separated visually, then the
method should be split up into multiple methods.

-Nathan

On 11/27/06, Ivanov, Alexey A <al...@intel.com> wrote:
> Nathan,
>
>
>
> Do you thing empty lines in tests are useless? Why have you removed
> every single empty line in tests?
>
> They were there on purpose! They separate parts of a unit test. I don't
> want them to be dropped! The code is unreadable without them.
>
>
>
> Thank you in advance,
>
> Alexey.
>
>
>
> --
> Alexey A. Ivanov
> Intel Enterprise Solutions Software Division
>
>
>
>
>