[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3276: Return from task execution if send fails as there is nothing more to do

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #3276:
URL: https://github.com/apache/arrow-datafusion/pull/3276#discussion_r956403122


##########
datafusion/core/src/physical_plan/common.rs:
##########
@@ -192,8 +192,10 @@ pub(crate) fn spawn_execution(
 
         while let Some(item) = stream.next().await {
             // If send fails, plan being torn down,
-            // there is no place to send the error
-            output.send(item).await.ok();
+            // there is no place to send the error.
+            if let Err(_) = output.send(item).await {
+                return;

Review Comment:
   The change looks reasonable, but I think we should at least log a debug or warning message rather than silently consuming the error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org