[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1697: tools/configure.sh: Add --list option to list all available configurations

[GitBox <gi...@apache.org>]

v01d commented on a change in pull request #1697:
URL: https://github.com/apache/incubator-nuttx/pull/1697#discussion_r482236801



##########
File path: tools/configure.sh
##########
@@ -134,13 +150,7 @@ if [ ! -d ${configpath} ]; then
     echo "Directory for ${boardconfig} does not exist.  Options are:"
     echo ""
     echo "Select one of the following options for <board-name>:"
-    configlist=`find ${TOPDIR}/boards -name defconfig`
-    for defconfig in ${configlist}; do
-      config=`dirname ${defconfig} | sed -e "s,${TOPDIR}/boards/,,g"`
-      boardname=`echo ${config} | cut -d'/' -f3`
-      configname=`echo ${config} | cut -d'/' -f5`
-      echo "  ${boardname}:${configname}"
-    done
+    dumpcfgs

Review comment:
       Since there's now an explicit list option wouldn't it be better to just indicate "use --list for listing boards"? this way if you mess up the parameters you don't get the long list and just the error instead




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org