You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/25 08:06:38 UTC
[GitHub] [ozone] sky76093016 opened a new pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
sky76093016 opened a new pull request #2370:
URL: https://github.com/apache/ozone/pull/2370
## What changes were proposed in this pull request?
The new version of o3fs must require Service ID.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5389
## How was this patch tested?
Local Hugo pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658618515
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,7 +59,7 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume</value>
+ <value>o3fs://bucket.volume.OzoneServiceId</value>
Review comment:
This is not a HA document, is it better to keep `o3fs://bucket.volume`?
The tip is placed below as a reminder.
Do @bharatviswa504 have any better suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658670610
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,10 +59,15 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume.OzoneServiceId</value>
+ <value>o3fs://bucket.volume</value>
</property>
```
+<div class="alert alert-warning" role="alert">
+
+Tip: For the OM HA cluster, you need to specify the ozone service id.
Review comment:
Let me modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658665436
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,10 +59,15 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume.OzoneServiceId</value>
+ <value>o3fs://bucket.volume</value>
</property>
```
+<div class="alert alert-warning" role="alert">
+
+Tip: For the OM HA cluster, you need to specify the ozone service id.
Review comment:
Your suggestion is also good, it will be more intuitive. Then I will combine the two, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658644418
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,7 +59,7 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume</value>
+ <value>o3fs://bucket.volume.OzoneServiceId</value>
Review comment:
Yes, better to keep o3fs://bucket.volume.
And I like the Tip idea, which communicates what is needed.
In the Tip in addition to specifying ozone service id give an example URL also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658615148
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,7 +59,7 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume</value>
+ <value>o3fs://bucket.volume.OzoneServiceId</value>
Review comment:
Thank @bharatviswa504 for review, can I change it to the following tip?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#issuecomment-868415263
Thanks for the suggestions provided by @bharatviswa504 , and the test on the local hugo shows that it is normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658616482
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,7 +59,7 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume</value>
+ <value>o3fs://bucket.volume.OzoneServiceId</value>
Review comment:
Looks good, what is the value you want to keep in fs.defaultFS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658597874
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,7 +59,7 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume</value>
+ <value>o3fs://bucket.volume.OzoneServiceId</value>
Review comment:
Can we add a some explanation here for OM HA cluster that ozone service id need to be specified, for non-ha it can be just o3fs://bucket.volume
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658670214
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,10 +59,15 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume.OzoneServiceId</value>
+ <value>o3fs://bucket.volume</value>
</property>
```
+<div class="alert alert-warning" role="alert">
+
+Tip: For the OM HA cluster, you need to specify the ozone service id.
Review comment:
Yes, looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang merged pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
jojochuang merged pull request #2370:
URL: https://github.com/apache/ozone/pull/2370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658666605
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,10 +59,15 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume.OzoneServiceId</value>
+ <value>o3fs://bucket.volume</value>
</property>
```
+<div class="alert alert-warning" role="alert">
+
+Tip: For the OM HA cluster, you need to specify the ozone service id.
Review comment:
like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658655565
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,10 +59,15 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume.OzoneServiceId</value>
+ <value>o3fs://bucket.volume</value>
</property>
```
+<div class="alert alert-warning" role="alert">
+
+Tip: For the OM HA cluster, you need to specify the ozone service id.
Review comment:
Modify it like `Tip: For the [OM HA]({{< ref "feature/OM-HA.md">}}) cluster`？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658644805
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,10 +59,15 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume.OzoneServiceId</value>
+ <value>o3fs://bucket.volume</value>
</property>
```
+<div class="alert alert-warning" role="alert">
+
+Tip: For the OM HA cluster, you need to specify the ozone service id.
Review comment:
Add an example URL also for HA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658618515
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,7 +59,7 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume</value>
+ <value>o3fs://bucket.volume.OzoneServiceId</value>
Review comment:
This is not a HA document, is it better to keep `o3fs://bucket.volume`?
The tip is placed below as a reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658664394
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,10 +59,15 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume.OzoneServiceId</value>
+ <value>o3fs://bucket.volume</value>
</property>
```
+<div class="alert alert-warning" role="alert">
+
+Tip: For the OM HA cluster, you need to specify the ozone service id.
Review comment:
Ya that would be also good. But giving an example here would be a good idea. As this doc talks in general about O3fs.
**Example as below**
Tip: For the OM HA cluster, you need to specify the ozone service id. For example, if ozone.om.service.ids = ozone1, then the URL is o3fs://bucket.volume.ozone1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2370: HDDS-5389. Include ozoneserviceid in fs.defaultFS when configuring o3fs
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2370:
URL: https://github.com/apache/ozone/pull/2370#discussion_r658618515
##########
File path: hadoop-hdds/docs/content/interface/O3fs.md
##########
@@ -59,7 +59,7 @@ Please add the following entry to the core-site.xml.
</property>
<property>
<name>fs.defaultFS</name>
- <value>o3fs://bucket.volume</value>
+ <value>o3fs://bucket.volume.OzoneServiceId</value>
Review comment:
This is not a HA document, is it better to keep `o3fs://bucket.volume`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org