You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/06 06:28:53 UTC

[GitHub] [airflow] pankajastro opened a new pull request, #22772: Fail LocalFilesystemToGCSOperator if src does not exist

pankajastro opened a new pull request, #22772:
URL: https://github.com/apache/airflow/pull/22772

   Fail LocalFilesystemToGCSOperator if the src file does not exist
   
   `src` argument of LocalFilesystemToGCSOperator accept either list of source file path or a single source file path as a string. In the case of a single source file path we are using [glob](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/transfers/local_to_gcs.py#L111) to parse the file path and glob return empty list if file path does not exist. In the next step, we iterate on this list and call [hook api](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/transfers/local_to_gcs.py#L123) to update the file since the list is empty control is not going inside loop and task is succeeding even if the source file is not available.
   
   Change 
   - Raise an exception if [filepath](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/transfers/local_to_gcs.py#L111) list is empty
   
   After this change below task will fail if example-text.txt does not exist
   
   ```
   upload_file = LocalFilesystemToGCSOperator(
           task_id="upload_file",
           src="example-text.txt",
           dst=DESTINATION_FILE_LOCATION,
           bucket=BUCKET_NAME,
       )
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22772: Fail LocalFilesystemToGCSOperator if src does not exist

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #22772:
URL: https://github.com/apache/airflow/pull/22772#issuecomment-1089871771

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #22772: Fail LocalFilesystemToGCSOperator if src does not exist

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #22772:
URL: https://github.com/apache/airflow/pull/22772#issuecomment-1090569418

   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22772: Fail LocalFilesystemToGCSOperator if src does not exist

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #22772:
URL: https://github.com/apache/airflow/pull/22772#issuecomment-1090672163

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #22772: Fail LocalFilesystemToGCSOperator if src does not exist

Posted by GitBox <gi...@apache.org>.

kaxil merged PR #22772:
URL: https://github.com/apache/airflow/pull/22772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pankajastro commented on a diff in pull request #22772: Fail LocalFilesystemToGCSOperator if src does not exist

Posted by GitBox <gi...@apache.org>.

pankajastro commented on code in PR #22772:
URL: https://github.com/apache/airflow/pull/22772#discussion_r843921470


##########
airflow/providers/google/cloud/transfers/local_to_gcs.py:
##########
@@ -109,6 +109,8 @@ def execute(self, context: 'Context'):
         )
 
         filepaths = self.src if isinstance(self.src, list) else glob(self.src)
+        if len(filepaths) == 0:
+            raise ValueError(f"src {self.src} dos not exist.")

Review Comment:
   Updated with the above change 42cbdb734990e8d7f8cebf987791c552b384b951



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a diff in pull request #22772: Fail LocalFilesystemToGCSOperator if src does not exist

Posted by GitBox <gi...@apache.org>.

uranusjr commented on code in PR #22772:
URL: https://github.com/apache/airflow/pull/22772#discussion_r843555640


##########
airflow/providers/google/cloud/transfers/local_to_gcs.py:
##########
@@ -109,6 +109,8 @@ def execute(self, context: 'Context'):
         )
 
         filepaths = self.src if isinstance(self.src, list) else glob(self.src)
+        if len(filepaths) == 0:
+            raise ValueError(f"src {self.src} dos not exist.")

Review Comment:
   ```suggestion
           if not filepaths:
               raise FileNotFoundError(self.src)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org