You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/22 17:28:21 UTC

[GitHub] [arrow] wesm commented on pull request #7213: ARROW-8841: [C++] Add benchmark and unittest for encoding::PLAIN spaced

wesm commented on pull request #7213:
URL: https://github.com/apache/arrow/pull/7213#issuecomment-632819189


   I just stumbled on failures on MSVC in these benchmarks (see https://issues.apache.org/jira/browse/ARROW-8892). I'm fixing the immediate issues that I found but the problem of checking that benchmarks compile in CI will have to be done separately
   
   In general, I think we should be less liberal about using `auto` to help avoid issues like this. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org