You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/31 11:46:02 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #2989: [minor] Clean up uneeded environment variables in CI
alamb opened a new pull request, #2989:
URL: https://github.com/apache/arrow-datafusion/pull/2989
# Which issue does this PR close?
N/A
# Rationale for this change
In the context of https://github.com/apache/arrow-rs/issues/2149 I spent a lot of time reviewing github workflow definitions and so naturally I also started looking at the datafusion ones as well. IN my review, I found some leftover cruft from earlier times that I think is no longer necessary
# What changes are included in this PR?
Remove unecessary environment variable definitions in Rust CI definitions
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2989: [minor] Clean up uneeded environment variables in CI
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2989:
URL: https://github.com/apache/arrow-datafusion/pull/2989#issuecomment-1200504498
aaand all the CI checks passed without the variables 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #2989: [minor] Clean up uneeded environment variables in CI
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2989:
URL: https://github.com/apache/arrow-datafusion/pull/2989#issuecomment-1200610867
Benchmark runs are scheduled for baseline = 193fc3b4549ed40a08218b744388f9211605ab53 and contender = c179102492b9b5463c4751c4637a01547b6f2b7b. c179102492b9b5463c4751c4637a01547b6f2b7b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c0a64bbf8789401aa93764d478d27780...e7592381f3e94659a72946e0044e9e34/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/769a4846b4a24e359847b1f6df27b019...09ddc3f55eb3495b8227f83b4feec3e2/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/42649c0f9b794621ab327ec61b6c1fbe...2d0bbc0c57b64088a6efbb5eb48aeff2/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/01753db65b5d44f5946b38748d17657c...5890439566404de2a905db49aaba75de/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen merged pull request #2989: [minor] Clean up uneeded environment variables in CI
Posted by GitBox <gi...@apache.org>.
yjshen merged PR #2989:
URL: https://github.com/apache/arrow-datafusion/pull/2989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2989: [minor] Clean up uneeded environment variables in CI
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2989:
URL: https://github.com/apache/arrow-datafusion/pull/2989#issuecomment-1200413673
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2989?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2989](https://codecov.io/gh/apache/arrow-datafusion/pull/2989?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f53f8a9) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/c7fa789e85025a631ed634881e60c1ed71e8d269?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c7fa789) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2989 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 282 282
Lines 51531 51531
=======================================
+ Hits 44219 44222 +3
+ Misses 7312 7309 -3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/2989?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.77% <0.00%> (+0.34%)` | :arrow_up: |
| [datafusion/core/src/physical\_plan/metrics/value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2989/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL21ldHJpY3MvdmFsdWUucnM=) | `87.43% <0.00%> (+0.50%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org