You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by dhatchayani <gi...@git.apache.org> on 2018/07/25 09:12:23 UTC

[GitHub] carbondata pull request #2555: [CARBONDATA-2753][Compatibility] Row count of...

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/2555

    [CARBONDATA-2753][Compatibility] Row count of page is calculated wrong for old store(V2 store)

    Row count of page is calculated wrong for V2 store.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [x] Testing done
           Manual Testing
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/carbondata CARBONDATA-2753_Row_Count

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2555
    
----
commit 2d893ca3fee09b6176a31f02dc84f41de5690bc7
Author: dhatchayani <dh...@...>
Date:   2018-07-25T09:11:58Z

    [CARBONDATA-2753][Compatibility] Row count of page is calculated wrong for old store(V2 store)

----


---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    retest sdv please


---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6249/



---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by Indhumathi27 <gi...@git.apache.org>.
Github user Indhumathi27 commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    retest sdv please


---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    Retest sdv please


---

[GitHub] carbondata pull request #2555: [CARBONDATA-2753][Compatibility] Row count of...

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani closed the pull request at:

    https://github.com/apache/carbondata/pull/2555


---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6046/



---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7497/



---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6054/



---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    LGTM


---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6024/



---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7507/



---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    retest sdv please


---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6256/



---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    LGTM


---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    @dhatchayani i have merged this pr please close 


---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    retest this please


---

[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...

Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/2555
  
    retest sdv please


---