[jira] [Commented] (TAJO-460) CTAS statement should support partitioned table

["Hyunsik Choi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858349#comment-13858349 ] 

Hyunsik Choi commented on TAJO-460:
-----------------------------------

Nice job! the patch looks good for me.

By the way, there is something to be checked. TestInsertQuery causes test failures after this patch because the following line causes NPE in some tests.
{code:title=473 line in GlobalEngine}
queryContext.setPartitions(storeTableNode.getPartitions());
{code}

The main cause is that storeTableNode does not always have PartitionDesc instance.

Besides, I'm expecting that you were very confuse because so far, we have used the word 'partition' to indicate shuffle. So, I've just created an refactoring issue (TAJO-464) to rename 'partition' actually meaning 'shuffle' to 'shuffle'.

Thanks!

> CTAS statement should support partitioned table 
> ------------------------------------------------
>
>                 Key: TAJO-460
>                 URL: https://issues.apache.org/jira/browse/TAJO-460
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: planner/optimizer
>    Affects Versions: 0.8-incubating
>            Reporter: Min Zhou
>            Assignee: Min Zhou
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-460.diff
>
>
> This would be more convenient if we implement it. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)