[GitHub] [airflow] Taragolis commented on pull request #25609: Remove deprecated modules from Amazon provider package

[GitBox <gi...@apache.org>]

Taragolis commented on PR #25609:
URL: https://github.com/apache/airflow/pull/25609#issuecomment-1208635776

   Selected tests not relevant anymore and could be removed
   
   **test_get_client_type_returns_a_boto3_client_of_the_requested_type**
   https://github.com/apache/airflow/blob/72a6ac5e54b6ab682861537e37abcd97f405d911/tests/providers/amazon/aws/hooks/test_base_aws.py#L223-L232
   
   **test_get_client_type_overwrite**
   https://github.com/apache/airflow/blob/72a6ac5e54b6ab682861537e37abcd97f405d911/tests/providers/amazon/aws/hooks/test_base_aws.py#L245-L253
   
   **test_get_client_type_deprecation_warning**
   https://github.com/apache/airflow/blob/72a6ac5e54b6ab682861537e37abcd97f405d911/tests/providers/amazon/aws/hooks/test_base_aws.py#L255-L262
   
   **test_get_resource_type_returns_a_boto3_resource_of_the_requested_type**
   https://github.com/apache/airflow/blob/72a6ac5e54b6ab682861537e37abcd97f405d911/tests/providers/amazon/aws/hooks/test_base_aws.py#L264-L282
   
   **test_get_resource_type_overwrite**
   https://github.com/apache/airflow/blob/72a6ac5e54b6ab682861537e37abcd97f405d911/tests/providers/amazon/aws/hooks/test_base_aws.py#L304-L322
   
   **test_get_resource_deprecation_warning**
   https://github.com/apache/airflow/blob/72a6ac5e54b6ab682861537e37abcd97f405d911/tests/providers/amazon/aws/hooks/test_base_aws.py#L324-L331
   
   ---
   
   **test_refreshable_credentials** uses removed attribute
   
   Quick hotfix:
   
   1. In hook specify `client_type='sts'`
   https://github.com/apache/airflow/blob/72a6ac5e54b6ab682861537e37abcd97f405d911/tests/providers/amazon/aws/hooks/test_base_aws.py#L623-L625
   
   2. `hook.get_client_type('sts')` -> `hook.get_client_type()`
   https://github.com/apache/airflow/blob/72a6ac5e54b6ab682861537e37abcd97f405d911/tests/providers/amazon/aws/hooks/test_base_aws.py#L662-L664
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org