You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ldrozdo (via GitHub)" <gi...@apache.org> on 2023/03/13 08:25:08 UTC
[GitHub] [camel-quarkus] ldrozdo opened a new pull request, #4646: Ref #4596: Create jdbc tests for generated keys and other headers
ldrozdo opened a new pull request, #4646:
URL: https://github.com/apache/camel-quarkus/pull/4646
Partially fixes #4596:
1. Generated keys
2. Message headers ( except for CamelJdbcParameters header, which will be done in the next PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4646: Ref #4596: Create jdbc tests for generated keys and other headers
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on code in PR #4646:
URL: https://github.com/apache/camel-quarkus/pull/4646#discussion_r1133613856
##########
integration-tests/jdbc/src/test/java/org/apache/camel/quarkus/component/jdbc/CamelJdbcTest.java:
##########
@@ -16,14 +16,17 @@
*/
package org.apache.camel.quarkus.component.jdbc;
+import java.util.List;
+
import io.quarkus.test.common.QuarkusTestResource;
import io.quarkus.test.h2.H2DatabaseTestResource;
import io.quarkus.test.junit.QuarkusTest;
import io.restassured.RestAssured;
import io.restassured.http.ContentType;
import org.junit.jupiter.api.Test;
-import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.*;
Review Comment:
Same comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4646: Ref #4596: Create jdbc tests for generated keys and other headers
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4646:
URL: https://github.com/apache/camel-quarkus/pull/4646#discussion_r1133612467
##########
integration-tests/jdbc/src/main/java/org/apache/camel/quarkus/component/jdbc/CamelResource.java:
##########
@@ -109,4 +107,29 @@ public String getSpeciesByIdWithDefinedType(@PathParam("id") String id) throws E
public String executeStatement(String statement) throws Exception {
return template.requestBody("jdbc:camel-ds", statement, String.class);
}
+
+ @Path("/generated-keys/rows")
+ @GET
+ @Produces(MediaType.APPLICATION_JSON)
+ public List generatedKeysRows() throws Exception {
+ return template.requestBodyAndHeader("direct://get-generated-keys",
+ "insert into camelsGenerated (species) values ('Camelus testus'), ('Camelus redhatus')",
Review Comment:
Shouldn't we avoid to refer to company names ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4646: Ref #4596: Create jdbc tests for generated keys and other headers
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on code in PR #4646:
URL: https://github.com/apache/camel-quarkus/pull/4646#discussion_r1133611487
##########
integration-tests/jdbc/src/main/java/org/apache/camel/quarkus/component/jdbc/CamelResource.java:
##########
@@ -27,12 +28,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.enterprise.context.ApplicationScoped;
import jakarta.inject.Inject;
-import jakarta.ws.rs.Consumes;
-import jakarta.ws.rs.GET;
-import jakarta.ws.rs.POST;
-import jakarta.ws.rs.Path;
-import jakarta.ws.rs.PathParam;
-import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.*;
Review Comment:
I guess this one is related to your IDE configuration.
Can you please revert importing all the package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #4646: Ref #4596: Create jdbc tests for generated keys and other headers
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger merged PR #4646:
URL: https://github.com/apache/camel-quarkus/pull/4646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org