You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/21 08:52:00 UTC
[jira] [Work logged] (BEAM-3892) Make MetricQueryResults and
related classes more json-serialization friendly
[ https://issues.apache.org/jira/browse/BEAM-3892?focusedWorklogId=82683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82683 ]
ASF GitHub Bot logged work on BEAM-3892:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/18 08:51
Start Date: 21/Mar/18 08:51
Worklog Time Spent: 10m
Work Description: echauchot opened a new pull request #4918: [BEAM-3892] Make MetricQueryResults and related classes more json-serialization friendly
URL: https://github.com/apache/beam/pull/4918
Update the experimental MetricQueryResults API to make MetricQueryResults implementations and related classes more json-serialization friendly. Among other things to be able to push them to external sinks.
This PR just renames accessors to get*() to be able to use default json serializers (no serialization code to maintain and no DTO added)
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [X] Write a pull request description that is detailed enough to understand:
- [X] What the pull request does
- [X] Why it does it
- [X] How it does it
- [X] Why this approach
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [X] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 82683)
Time Spent: 10m
Remaining Estimate: 0h
> Make MetricQueryResults and related classes more json-serialization friendly
> ----------------------------------------------------------------------------
>
> Key: BEAM-3892
> URL: https://issues.apache.org/jira/browse/BEAM-3892
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When working on this PR [https://github.com/apache/beam/pull/4548] MetricQueryResults needed to be serialized to be pushed to a metrics sink. As they were it required a custom serializer that just calls the name(), counter(), committed(), attempted() ... methods. MetricQueryResults are so close to be serializable with the default serializer, just need the accessors to be renamed get*, that creating DTO objects with get* methods to just call the non-get methods seems unnecessary.
> So just rename public accessors to get* on the experimental API
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)