You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2020/10/19 14:41:31 UTC
[incubator-echarts] branch next updated: fix(animation): disable
additive animation since it's still having issues.
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/next by this push:
new 7da95db fix(animation): disable additive animation since it's still having issues.
7da95db is described below
commit 7da95dba57c5e9fe197c41ef64a0dacb7636f746
Author: pissang <bm...@gmail.com>
AuthorDate: Mon Oct 19 22:40:44 2020 +0800
fix(animation): disable additive animation since it's still having issues.
---
src/echarts.ts | 4 ++--
src/model/globalDefault.ts | 4 ++--
src/util/types.ts | 2 +-
test/custom-children-remove.html | 2 +-
test/custom.html | 4 ++--
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/echarts.ts b/src/echarts.ts
index 841652f..6deb283 100644
--- a/src/echarts.ts
+++ b/src/echarts.ts
@@ -2165,8 +2165,8 @@ class ECharts extends Eventful {
const stateTransition = duration > 0 ? {
duration,
delay: stateAnimationModel.get('delay'),
- easing: stateAnimationModel.get('easing'),
- additive: stateAnimationModel.get('additive')
+ easing: stateAnimationModel.get('easing')
+ // additive: stateAnimationModel.get('additive')
} : null;
view.group.traverse(function (el: Displayable) {
if (el.states && el.states.emphasis) {
diff --git a/src/model/globalDefault.ts b/src/model/globalDefault.ts
index c25ee59..6e67a12 100644
--- a/src/model/globalDefault.ts
+++ b/src/model/globalDefault.ts
@@ -75,8 +75,8 @@ export default {
stateAnimation: {
duration: 300,
- easing: 'cubicOut',
- additive: true
+ easing: 'cubicOut'
+ // additive: true
},
animation: 'auto',
diff --git a/src/util/types.ts b/src/util/types.ts
index f014c2e..bac8103 100644
--- a/src/util/types.ts
+++ b/src/util/types.ts
@@ -698,7 +698,7 @@ export interface AnimationOption {
duration?: number
easing?: AnimationEasing
delay?: number
- additive?: boolean
+ // additive?: boolean
}
/**
* Mixin of option set to control the animation of series.
diff --git a/test/custom-children-remove.html b/test/custom-children-remove.html
index 20eedd1..c7333bd 100644
--- a/test/custom-children-remove.html
+++ b/test/custom-children-remove.html
@@ -126,7 +126,7 @@ under the License.
currentSeriesIndices.pop(); // remove custom series;
var barLayout = api.barLayout({
- barGap: '30%', barCategoryGap: '20%', count: currentSeriesIndices.length
+ count: currentSeriesIndices.length
});
var nameTexts = echarts.util.map(currentSeriesIndices, function (serIdx, index) {
diff --git a/test/custom.html b/test/custom.html
index b778da9..4a16aa4 100644
--- a/test/custom.html
+++ b/test/custom.html
@@ -739,7 +739,7 @@ under the License.
var xValue = api.value(0);
var currentSeriesIndices = api.currentSeriesIndices();
var barLayout = api.barLayout({
- barGap: '30%', barCategoryGap: '20%', count: currentSeriesIndices.length - 1
+ count: currentSeriesIndices.length - 1
});
var points = [];
@@ -1380,7 +1380,7 @@ under the License.
currentSeriesIndices.pop(); // remove custom series;
var barLayout = api.barLayout({
- barGap: '30%', barCategoryGap: '20%', count: currentSeriesIndices.length
+ count: currentSeriesIndices.length
});
var nameTexts = echarts.util.map(currentSeriesIndices, function (serIdx, index) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org