You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/16 06:00:49 UTC
[GitHub] [couchdb] nickva opened a new pull request #2459: Add a few missing
settings to the default.ini file
nickva opened a new pull request #2459: Add a few missing settings to the default.ini file
URL: https://github.com/apache/couchdb/pull/2459
Some rexi and reshard parameters
Issue: https://github.com/apache/couchdb/issues/2457
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on a change in pull request #2459: Add a
few missing settings to the default.ini file
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file
URL: https://github.com/apache/couchdb/pull/2459#discussion_r367572953
##########
File path: rel/overlay/etc/default.ini
##########
@@ -578,3 +584,44 @@ compaction = false
; CouchDB will use the value of `max_limit` instead. If neither is
; defined, the default is 2000 as stated here.
; max_limit_partitions = 2000
+
+[reshard]
+; Maximum resharding jobs allowed. New jobs cannot be added until some
+; old ones are deleted. A finished job is not automatically
+; removed. It has to be removed by hand.
Review comment:
`max_jobs` effect is mentioned in the guide
> The total number of jobs is important to keep an eye on because there is a maximum number of resharding jobs per node, and creating new jobs after the limit has been reached will result in an error. Before staring new jobs it's a good idea to remove already completed jobs. See :ref:`reshard configuration section <config/reshard>` for the default value of max_jobs parameter and how to adjust if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on a change in pull request #2459: Add a
few missing settings to the default.ini file
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file
URL: https://github.com/apache/couchdb/pull/2459#discussion_r367541977
##########
File path: rel/overlay/etc/default.ini
##########
@@ -578,3 +584,44 @@ compaction = false
; CouchDB will use the value of `max_limit` instead. If neither is
; defined, the default is 2000 as stated here.
; max_limit_partitions = 2000
+
+[reshard]
+; Maximum resharding jobs allowed. New jobs cannot be added until some
+; old ones are deleted. A finished job is not automatically
+; removed. It has to be removed by hand.
Review comment:
Good catch, I will update it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on a change in pull request #2459: Add a
few missing settings to the default.ini file
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file
URL: https://github.com/apache/couchdb/pull/2459#discussion_r367574179
##########
File path: rel/overlay/etc/default.ini
##########
@@ -578,3 +584,44 @@ compaction = false
; CouchDB will use the value of `max_limit` instead. If neither is
; defined, the default is 2000 as stated here.
; max_limit_partitions = 2000
+
+[reshard]
+; Maximum resharding jobs allowed. New jobs cannot be added until some
+; old ones are deleted. A finished job is not automatically
+; removed. It has to be removed by hand.
+;max_jobs = 48
+;
+; Time to wait before retrying a failed shard splitting phase.
Review comment:
Fixed in this documentation PR:
https://github.com/apache/couchdb-documentation/pull/478
I had also opted to keep the description in the documentation to avoid redundancy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] wohali commented on a change in pull request #2459: Add a
few missing settings to the default.ini file
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #2459: Add a few missing settings to the default.ini file
URL: https://github.com/apache/couchdb/pull/2459#discussion_r367487521
##########
File path: rel/overlay/etc/default.ini
##########
@@ -578,3 +584,44 @@ compaction = false
; CouchDB will use the value of `max_limit` instead. If neither is
; defined, the default is 2000 as stated here.
; max_limit_partitions = 2000
+
+[reshard]
+; Maximum resharding jobs allowed. New jobs cannot be added until some
+; old ones are deleted. A finished job is not automatically
+; removed. It has to be removed by hand.
Review comment:
This seems a pretty important distinction from replication, and it's not present in the docs repo:
https://github.com/apache/couchdb-documentation/blob/a35ea115a71fd27a21245a6f14becf43adcfc8a7/src/config/resharding.rst
Nor is it here:
https://github.com/apache/couchdb-documentation/blob/a35ea115a71fd27a21245a6f14becf43adcfc8a7/src/cluster/sharding.rst
Can you add it there please? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva merged pull request #2459: Add a few missing
settings to the default.ini file
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #2459: Add a few missing settings to the default.ini file
URL: https://github.com/apache/couchdb/pull/2459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on a change in pull request #2459: Add a
few missing settings to the default.ini file
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file
URL: https://github.com/apache/couchdb/pull/2459#discussion_r368016920
##########
File path: rel/overlay/etc/default.ini
##########
@@ -578,3 +584,44 @@ compaction = false
; CouchDB will use the value of `max_limit` instead. If neither is
; defined, the default is 2000 as stated here.
; max_limit_partitions = 2000
+
+[reshard]
+; Maximum resharding jobs allowed. New jobs cannot be added until some
+; old ones are deleted. A finished job is not automatically
+; removed. It has to be removed by hand.
+;max_jobs = 48
+;
+; Time to wait before retrying a failed shard splitting phase.
Review comment:
docs PR merged upstream
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] wohali commented on a change in pull request #2459: Add a
few missing settings to the default.ini file
Posted by GitBox <gi...@apache.org>.
wohali commented on a change in pull request #2459: Add a few missing settings to the default.ini file
URL: https://github.com/apache/couchdb/pull/2459#discussion_r367487972
##########
File path: rel/overlay/etc/default.ini
##########
@@ -578,3 +584,44 @@ compaction = false
; CouchDB will use the value of `max_limit` instead. If neither is
; defined, the default is 2000 as stated here.
; max_limit_partitions = 2000
+
+[reshard]
+; Maximum resharding jobs allowed. New jobs cannot be added until some
+; old ones are deleted. A finished job is not automatically
+; removed. It has to be removed by hand.
+;max_jobs = 48
+;
+; Time to wait before retrying a failed shard splitting phase.
Review comment:
Realising that the docs here vs. https://github.com/apache/couchdb-documentation/blob/a35ea115a71fd27a21245a6f14becf43adcfc8a7/src/config/resharding.rst are not in sync, can you make the text identical in each place? Sometimes your new description here is better, sometimes the one in the docs repo is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on a change in pull request #2459: Add a
few missing settings to the default.ini file
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file
URL: https://github.com/apache/couchdb/pull/2459#discussion_r367542195
##########
File path: rel/overlay/etc/default.ini
##########
@@ -578,3 +584,44 @@ compaction = false
; CouchDB will use the value of `max_limit` instead. If neither is
; defined, the default is 2000 as stated here.
; max_limit_partitions = 2000
+
+[reshard]
+; Maximum resharding jobs allowed. New jobs cannot be added until some
+; old ones are deleted. A finished job is not automatically
+; removed. It has to be removed by hand.
+;max_jobs = 48
+;
+; Time to wait before retrying a failed shard splitting phase.
Review comment:
Another good catch, the main docs are outdated, will make a PR to update them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services