You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/08/04 19:12:18 UTC
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18816
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
IMPALA-11458: Update zlib, zstd, snappy
Updates zlib to 1.2.12, zstd to 1.5.2, and snappy to 1.1.9. Requires a
new toolchain build.
Change-Id: If96fd5e8c49e581478b249bb8894001457742023
---
M bin/impala-config.sh
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/18816/1
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 5:
Did a rebase. I guess that'll need a re-run.
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 23:25:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18816
to look at the new patch set (#4).
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
IMPALA-11458: Update zlib and zstd
Updates zlib to 1.2.12 and zstd to 1.5.2. Requires a new toolchain
build.
Change-Id: If96fd5e8c49e581478b249bb8894001457742023
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/18816/4
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
IMPALA-11458: Update zlib and zstd
Updates zlib to 1.2.12 and zstd to 1.5.2. Requires a new toolchain
build.
Ran perf-AB-test to check for performance changes with parquet using
zstd and gzip. Only significant changes were slight improvement with
gzip.
Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Reviewed-on: http://gerrit.cloudera.org:8080/18816
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8415/
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 01:24:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18816
to look at the new patch set (#2).
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
IMPALA-11458: Update zlib, zstd, snappy
Updates zlib to 1.2.12, zstd to 1.5.2, and snappy to 1.1.9. Requires a
new toolchain build.
The snappy update made some parquet files in the
stats-extrapolation.test slightly larger, leading to slightly different
estimates. I've checked that the data stored is unchanged with
`select * from alltypes` on tables written before and after this change.
Change-Id: If96fd5e8c49e581478b249bb8894001457742023
---
M bin/impala-config.sh
M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test
2 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/18816/2
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 4:
Tests hit IMPALA-11160, IMPALA-11352. Rebuilding.
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 17:09:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11121/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 20:43:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8402/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 19:13:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8402/
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Aug 2022 00:06:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11108/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Aug 2022 22:10:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8421/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 17:10:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18816
to look at the new patch set (#5).
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
IMPALA-11458: Update zlib and zstd
Updates zlib to 1.2.12 and zstd to 1.5.2. Requires a new toolchain
build.
Ran perf-AB-test to check for performance changes with parquet using
zstd and gzip. Only significant changes were slight improvement with
gzip.
Change-Id: If96fd5e8c49e581478b249bb8894001457742023
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/18816/5
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 5: Verified+1 Code-Review+2
Carry +1 verified from last precommit run (only commit message change since then)
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 23:25:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 21:57:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Aug 2022 02:54:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 3:
The Snappy update appears to significantly regress performance. I'll remote it from the updates.
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 17:17:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Thanks for putting this together
Small nit about the commit message, but then we're ready to go. (I'll carry the +1 verified from your precommit run, so you wouldn't need to rerun.)
http://gerrit.cloudera.org:8080/#/c/18816/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18816/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-11458: Update zlib and zstd
:
: Updates zlib to 1.2.12 and zstd to 1.5.2. Requires a new toolchain
: build.
Can you mention the performance testing that we did. Just a couple line summary saying we ran TPC-H with zstd and zlib with no major regressions.
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 23:17:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18816/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18816/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-11458: Update zlib and zstd
:
: Updates zlib to 1.2.12 and zstd to 1.5.2. Requires a new toolchain
: build.
> Can you mention the performance testing that we did. Just a couple line sum
Done
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 23:24:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11127/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 23:45:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11099/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 19:32:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 1:
Depends on https://gerrit.cloudera.org/c/18795/.
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 19:12:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8406/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Aug 2022 22:02:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11458: Update zlib and zstd
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8415/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023
Gerrit-Change-Number: 18816
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 20:30:34 +0000
Gerrit-HasComments: No