You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/08/25 13:52:30 UTC
Review Request 37757: Installing Ambari-2.1.0 removes
/etc/sudoers.d/ambari-agent file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37757/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-12870
https://issues.apache.org/jira/browse/AMBARI-12870
Repository: ambari
Description
-------
As part of a prior fix, the file got removed from the rpm package. This has
the side effect of user edited file getting removed during upgrade.
Modify Ambari upgrade logic to not remove `/etc/sudoers.d/ambari-agent` and if
that is not possible at least make a copy of the file and save a backup.
Diffs
-----
ambari-agent/src/main/package/rpm/preinstall.sh fc6719b
Diff: https://reviews.apache.org/r/37757/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 37757: Installing Ambari-2.1.0 removes
/etc/sudoers.d/ambari-agent file
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37757/#review96524
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Сер. 26, 2015, 11:03 до полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37757/
> -----------------------------------------------------------
>
> (Updated Сер. 26, 2015, 11:03 до полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-12870
> https://issues.apache.org/jira/browse/AMBARI-12870
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As part of a prior fix, the file got removed from the rpm package. This has
> the side effect of user edited file getting removed during upgrade.
>
> Modify Ambari upgrade logic to not remove `/etc/sudoers.d/ambari-agent` and if
> that is not possible at least make a copy of the file and save a backup.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/package/deb/control/preinst e9fa78b
> ambari-agent/src/main/package/rpm/preinstall.sh e135c18
>
> Diff: https://reviews.apache.org/r/37757/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 37757: Installing Ambari-2.1.0 removes
/etc/sudoers.d/ambari-agent file
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37757/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 11:03 a.m.)
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-12870
https://issues.apache.org/jira/browse/AMBARI-12870
Repository: ambari
Description
-------
As part of a prior fix, the file got removed from the rpm package. This has
the side effect of user edited file getting removed during upgrade.
Modify Ambari upgrade logic to not remove `/etc/sudoers.d/ambari-agent` and if
that is not possible at least make a copy of the file and save a backup.
Diffs (updated)
-----
ambari-agent/src/main/package/deb/control/preinst e9fa78b
ambari-agent/src/main/package/rpm/preinstall.sh e135c18
Diff: https://reviews.apache.org/r/37757/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 37757: Installing Ambari-2.1.0 removes
/etc/sudoers.d/ambari-agent file
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37757/#review96328
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Сер. 25, 2015, 11:52 до полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37757/
> -----------------------------------------------------------
>
> (Updated Сер. 25, 2015, 11:52 до полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-12870
> https://issues.apache.org/jira/browse/AMBARI-12870
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As part of a prior fix, the file got removed from the rpm package. This has
> the side effect of user edited file getting removed during upgrade.
>
> Modify Ambari upgrade logic to not remove `/etc/sudoers.d/ambari-agent` and if
> that is not possible at least make a copy of the file and save a backup.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/package/rpm/preinstall.sh fc6719b
>
> Diff: https://reviews.apache.org/r/37757/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>