You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/28 16:49:39 UTC
[GitHub] [airflow] potiuk opened a new pull request #17290: Do not use constraints when preparing venv for k8s tests on CI
potiuk opened a new pull request #17290:
URL: https://github.com/apache/airflow/pull/17290
When k8s virtualenv is prepared to run k8s tests we are using
constraints, this however might lead to a problem when we increase
minimum version of an affected dependency and it conflicts with
the constraints stored in main.
Therefore in case we run tests in CI (which is indicated by
specific pull tag that we use) we do not use constraints for
installing the kubernetes venv. It should be fine, as we are
pretty much running this only as a vehicle to run tests.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17290: Do not use constraints when preparing venv for k8s tests on CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17290:
URL: https://github.com/apache/airflow/pull/17290#issuecomment-888486186
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17290: Do not use constraints when preparing venv for k8s tests on CI
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17290:
URL: https://github.com/apache/airflow/pull/17290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17290: Do not use constraints when preparing venv for k8s tests on CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17290:
URL: https://github.com/apache/airflow/pull/17290#issuecomment-888465965
Testing also in #17208 (ti was detected there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org