You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2023/03/01 22:09:03 UTC

[Bug 66502] New: tomcat-jdbc ConnectionPool.returnConnection() accept closed connections

https://bz.apache.org/bugzilla/show_bug.cgi?id=66502

            Bug ID: 66502
           Summary: tomcat-jdbc ConnectionPool.returnConnection() accept
                    closed connections
           Product: Tomcat 10
           Version: 10.1.6
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Util
          Assignee: dev@tomcat.apache.org
          Reporter: zyu@godaddy.com
  Target Milestone: ------

When a connection is checked out from pool, it could be forcefully closed by
the server. The connection is then returned to the connection pool, available
for more borrow/returns; the same broken connection causes plurals of failures
for the application, until `validationInterval` is reached when there's a
chance to evict the connection.

Proposal: PooledConnection.validate(VALIDATE_RETURN) checks underlying
`connection.isClosed()` unconditionally. This should be an inexpensive check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 66502] tomcat-jdbc ConnectionPool.returnConnection() accept closed connections

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66502

--- Comment #2 from Zhong Yu <zy...@godaddy.com> ---
Probably a duplicate of https://bz.apache.org/bugzilla/show_bug.cgi?id=64083

which has a pending PR: https://github.com/apache/tomcat/pull/235

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 66502] tomcat-jdbc ConnectionPool.returnConnection() accept closed connections

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66502

--- Comment #4 from Zhong Yu <zy...@godaddy.com> ---
wrong duplicate, Mark. should be 64083

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 66502] tomcat-jdbc ConnectionPool.returnConnection() accept closed connections

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66502

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---


*** This bug has been marked as a duplicate of bug 64803 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 66502] tomcat-jdbc ConnectionPool.returnConnection() accept closed connections

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66502

--- Comment #5 from Mark Thomas <ma...@apache.org> ---


*** This bug has been marked as a duplicate of bug 64083 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 66502] tomcat-jdbc ConnectionPool.returnConnection() accept closed connections

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66502

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|------                      |---
            Version|10.1.6                      |unspecified
            Product|Tomcat 10                   |Tomcat Modules
           Severity|normal                      |enhancement
          Component|Util                        |jdbc-pool

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Correct component and set as enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org