You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/06/11 13:02:43 UTC
[jira] [Created] (LUCENE-4129) add CodecHeader to .frq and .prx
Robert Muir created LUCENE-4129:
-----------------------------------
Summary: add CodecHeader to .frq and .prx
Key: LUCENE-4129
URL: https://issues.apache.org/jira/browse/LUCENE-4129
Project: Lucene - Java
Issue Type: Bug
Affects Versions: 4.0
Reporter: Robert Muir
Assignee: Robert Muir
We did this for all other files, but not .frq/.prx.
Currently the postings writer only records itself in the blocktree terms dictionary, which is fine, but thats really documenting the .tim itself, that it is "Blocktree with Lucene40Postings metadata".
I think we should put headers in .frq/.prx as well: e.g. it could detect file jumbling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4129) add CodecHeader to .frq and .prx
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292846#comment-13292846 ]
Robert Muir commented on LUCENE-4129:
-------------------------------------
I will look into the CFS stuff too after this one!
> add CodecHeader to .frq and .prx
> --------------------------------
>
> Key: LUCENE-4129
> URL: https://issues.apache.org/jira/browse/LUCENE-4129
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-4129.patch, LUCENE-4129.patch, LUCENE-4129.patch
>
>
> We did this for all other files, but not .frq/.prx.
> Currently the postings writer only records itself in the blocktree terms dictionary, which is fine, but thats really documenting the .tim itself, that it is "Blocktree with Lucene40Postings metadata".
> I think we should put headers in .frq/.prx as well: e.g. it could detect file jumbling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4129) add CodecHeader to .frq and .prx
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4129:
--------------------------------
Attachment: LUCENE-4129.patch
also added a test "TestAllFilesHaveCodecHeader". It currently has to ignore .cfs/cfe and also not recurse into them until we fix LUCENE-4130 and LUCENE-4131
> add CodecHeader to .frq and .prx
> --------------------------------
>
> Key: LUCENE-4129
> URL: https://issues.apache.org/jira/browse/LUCENE-4129
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-4129.patch, LUCENE-4129.patch, LUCENE-4129.patch
>
>
> We did this for all other files, but not .frq/.prx.
> Currently the postings writer only records itself in the blocktree terms dictionary, which is fine, but thats really documenting the .tim itself, that it is "Blocktree with Lucene40Postings metadata".
> I think we should put headers in .frq/.prx as well: e.g. it could detect file jumbling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4129) add CodecHeader to .frq and .prx
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4129:
--------------------------------
Attachment: LUCENE-4129.patch
updated patch to actually check the header :)
> add CodecHeader to .frq and .prx
> --------------------------------
>
> Key: LUCENE-4129
> URL: https://issues.apache.org/jira/browse/LUCENE-4129
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-4129.patch, LUCENE-4129.patch
>
>
> We did this for all other files, but not .frq/.prx.
> Currently the postings writer only records itself in the blocktree terms dictionary, which is fine, but thats really documenting the .tim itself, that it is "Blocktree with Lucene40Postings metadata".
> I think we should put headers in .frq/.prx as well: e.g. it could detect file jumbling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4129) add CodecHeader to .frq and .prx
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292842#comment-13292842 ]
Uwe Schindler commented on LUCENE-4129:
---------------------------------------
I am fine with the patch. I would like to fix the CFS issues, too. But we already have issue.
> add CodecHeader to .frq and .prx
> --------------------------------
>
> Key: LUCENE-4129
> URL: https://issues.apache.org/jira/browse/LUCENE-4129
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-4129.patch, LUCENE-4129.patch, LUCENE-4129.patch
>
>
> We did this for all other files, but not .frq/.prx.
> Currently the postings writer only records itself in the blocktree terms dictionary, which is fine, but thats really documenting the .tim itself, that it is "Blocktree with Lucene40Postings metadata".
> I think we should put headers in .frq/.prx as well: e.g. it could detect file jumbling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4129) add CodecHeader to .frq and .prx
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4129:
--------------------------------
Attachment: LUCENE-4129.patch
patch: this found a bug in NestedPulsing in the disk full tests.
I also changed pulsing to be more clear that the inner postings reader/writer is being closed here: theoretically its possible the pulsingreader/writer ctor could throw an exception and we would have a leak.
> add CodecHeader to .frq and .prx
> --------------------------------
>
> Key: LUCENE-4129
> URL: https://issues.apache.org/jira/browse/LUCENE-4129
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-4129.patch
>
>
> We did this for all other files, but not .frq/.prx.
> Currently the postings writer only records itself in the blocktree terms dictionary, which is fine, but thats really documenting the .tim itself, that it is "Blocktree with Lucene40Postings metadata".
> I think we should put headers in .frq/.prx as well: e.g. it could detect file jumbling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4129) add CodecHeader to .frq and .prx
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-4129.
---------------------------------
Resolution: Fixed
Fix Version/s: 5.0
4.0
> add CodecHeader to .frq and .prx
> --------------------------------
>
> Key: LUCENE-4129
> URL: https://issues.apache.org/jira/browse/LUCENE-4129
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4129.patch, LUCENE-4129.patch, LUCENE-4129.patch
>
>
> We did this for all other files, but not .frq/.prx.
> Currently the postings writer only records itself in the blocktree terms dictionary, which is fine, but thats really documenting the .tim itself, that it is "Blocktree with Lucene40Postings metadata".
> I think we should put headers in .frq/.prx as well: e.g. it could detect file jumbling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org