You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Appy (JIRA)" <ji...@apache.org> on 2018/01/26 21:09:00 UTC
[jira] [Comment Edited] (HBASE-19867) Split
TestStochasticLoadBalancer into several small tests
[ https://issues.apache.org/jira/browse/HBASE-19867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341600#comment-16341600 ]
Appy edited comment on HBASE-19867 at 1/26/18 9:08 PM:
-------------------------------------------------------
Add Timeout rule to enforce category based timeout.
Edit: Also, remove the "timeout=X" from @Test annotations.
{noformat}
@Rule
public final TestRule timeout = CategoryBasedTimeout.builder().withTimeout(this.getClass())
.withLookingForStuckThread(true).build();{noformat}
Looking at runtimes, it's probably enough to split it in lesser class? TSLBDifferentClusterSize, TSLBRegionReplica. Just suggestion, your call.
!image-2018-01-26-12-56-49-560.png|width=800!
Should we also split TestStochasticLoadBalancer2? It takes almost 10 minutes to run ([https://builds.apache.org/job/HBase%20Nightly/job/master/204/artifact/output-jdk8-hadoop2/patch-unit-root.txt/*view*/])
{noformat}
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 512.752 s - in org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2{noformat}
was (Author: appy):
Add Timeout rule to enforce category based timeout.
{noformat}
@Rule
public final TestRule timeout = CategoryBasedTimeout.builder().withTimeout(this.getClass())
.withLookingForStuckThread(true).build();{noformat}
Looking at runtimes, it's probably enough to split it in lesser class? TSLBDifferentClusterSize, TSLBRegionReplica. Just suggestion, your call.
!image-2018-01-26-12-56-49-560.png|width=800!
Should we also split TestStochasticLoadBalancer2? It takes almost 10 minutes to run (https://builds.apache.org/job/HBase%20Nightly/job/master/204/artifact/output-jdk8-hadoop2/patch-unit-root.txt/*view*/)
{noformat}
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 512.752 s - in org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2{noformat}
> Split TestStochasticLoadBalancer into several small tests
> ---------------------------------------------------------
>
> Key: HBASE-19867
> URL: https://issues.apache.org/jira/browse/HBASE-19867
> Project: HBase
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19867.patch, image-2018-01-26-12-56-49-560.png
>
>
> Just like what I have done to TestHCM.
> The test is CPU bound. We set a very large number of regions and also a very large number iterations which makes some of the tests execute for a very long time. It even make things worse that, our machines to run the jenkins job are very weak, so it will take much longer time than running them locally...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)